Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change canvas maximum farbling to match balanced farbling (uplift to 1.12.x) #6336

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Change canvas maximum farbling to match balanced farbling (uplift to 1.12.x) #6336

merged 1 commit into from
Aug 5, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 4, 2020 •
edited by kjozwiak
Loading

Uplift of #6324
Resolves brave/brave-browser#11067

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from bridiver as a code owner August 4, 2020 17:40
@brave-builds brave-builds requested a review from a team August 4, 2020 17:40
@brave-builds brave-builds self-assigned this Aug 4, 2020
@brave-builds brave-builds added this to the 1.12.x - Release milestone Aug 4, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 5, 2020

Restarting Win x64 as we lost the instance due to Agent was removed as per https://ci.brave.com/job/pr-brave-browser-pr6324_mpilgrim_canvas_max_1.12.x/1/execution/node/756/log/.

15:57:08  Cannot contact i-0e8ba5f206f3f0ca6: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@28bc5913:i-0e8ba5f206f3f0ca6": Remote call on i-0e8ba5f206f3f0ca6 failed. The channel is closing down or has closed down
16:02:06  Could not connect to i-0e8ba5f206f3f0ca6 to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Aug 5, 2020
kjozwiak
kjozwiak approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nighty as per #6324 (comment).

@kjozwiak kjozwiak merged commit c3b4110 into 1.12.x Aug 5, 2020
@kjozwiak kjozwiak deleted the pr6324_mpilgrim_canvas_max_1.12.x branch August 5, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases