Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes system-notification ads don't auto-dismiss after click/landing, nor do they time-out - 1.26.x #9165

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Fixes system-notification ads don't auto-dismiss after click/landing, nor do they time-out - 1.26.x #9165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...tive-ads/src/bat/ads/internal/ad_events/ad_notifications/ad_notification_event_clicked.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#include "bat/ads/confirmation_type.h"
#include "bat/ads/internal/ad_events/ad_events.h"
#include "bat/ads/internal/ads/ad_notifications/ad_notifications.h"
#include "bat/ads/internal/ads_client_helper.h"
#include "bat/ads/internal/ads_history/ads_history.h"
#include "bat/ads/internal/logging.h"

Expand All @@ -26,6 +27,8 @@ void AdEventClicked::FireEvent(const AdNotificationInfo& ad) {

AdNotifications::Get()->Remove(ad.uuid);

AdsClientHelper::Get()->CloseNotification(ad.uuid);

LogAdEvent(ad, ConfirmationType::kClicked, [](const Result result) {
if (result != Result::SUCCESS) {
BLOG(1, "Failed to log ad notification clicked event");
Expand Down