Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] fixes check permission crash (Uplift to 1.26.x) #9238

Merged
merged 2 commits into from
Jun 24, 2021
Merged

[Android] fixes check permission crash (Uplift to 1.26.x) #9238

merged 2 commits into from
Jun 24, 2021

Conversation

alexsafe
Copy link
Contributor

@alexsafe alexsafe commented Jun 24, 2021 •
edited by kjozwiak
Loading

Uplift of #9233
Resolves brave/brave-browser#16596

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jun 24, 2021
@alexsafe alexsafe added this to the 1.26.x - Release #2 milestone Jun 24, 2021
@alexsafe alexsafe requested a review from a team June 24, 2021 18:28
@alexsafe alexsafe self-assigned this Jun 24, 2021
@alexsafe alexsafe requested a review from a team as a code owner June 24, 2021 19:42
@alexsafe alexsafe changed the title [Android] fixes check permission crash [Android] fixes check permission crash (Uplift to 1.26.x) Jun 24, 2021
kjozwiak
kjozwiak approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.26.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 52b527c into 1.26.x Jun 24, 2021
@kjozwiak kjozwiak deleted the hf-permission-crash_1.26.x branch June 24, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@alexsafe alexsafe

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.26.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsafe @kjozwiak @bsclifton