Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] fixes check permission crash (Uplift to 1.26.x) #9238

Merged
merged 2 commits into from
Jun 24, 2021
Merged

[Android] fixes check permission crash (Uplift to 1.26.x) #9238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b121f1
[Android] fixes check permission crash
alexsafe Jun 24, 2021
f0ee8e4
Fix because Chromium 91 hasn't been upgraded in 1.27 yet
bsclifton Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion android/java/org/chromium/chrome/browser/brave_stats/BraveStatsUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,10 @@ private static Bitmap convertToBitmap(View view) {
}

public static boolean hasWritePermission(Activity activity) {
if (ActivityCompat.checkSelfPermission(activity, Manifest.permission.WRITE_EXTERNAL_STORAGE)
if (activity == null) {
return false;
}
if (activity.checkSelfPermission(Manifest.permission.WRITE_EXTERNAL_STORAGE)
== PackageManager.PERMISSION_GRANTED) {
return true;
}
Expand Down
2 changes: 1 addition & 1 deletion patches/chrome-VERSION.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ index 2428a6b7037e5a48cdab6c26665303294537bc4c..8528546f6be04ef25473d0ab53cb0944
MAJOR=91
-MINOR=0
-BUILD=4472
-PATCH=120
-PATCH=114
+MINOR=1
+BUILD=26
+PATCH=67