Fixed sentence casing on Always Show Full URLs in brave://settings/appearance

[deepxcode]

Fixes issue #16939
Changed "Always Show Full URLs" to "Always show full URLs"

Resolves #16939

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[deepxcode]

@petemill and @stephendonner Can you review this PR?

[swarup4741]

@deepxcode here we have a expr="not use_titlecase" for which we have the desired text casing and for expr="use_titlecase"... i think we must have capitalized format.. otherwise both are becoming the same essentially....

brave-core/app/generated_resources.grd

Lines 5226 to 5235 in 2d6b3a2

	<if expr="use_titlecase">
	<message name="IDS_CONTEXT_MENU_SHOW_FULL_URLS" desc="In Title Case: The text label of the omnibox context menu option to show full URLs">
	Always Show Full URLs
	</message>
	</if>
	<if expr="not use_titlecase">
	<message name="IDS_CONTEXT_MENU_SHOW_FULL_URLS" desc="The text label of the omnibox context menu option to show full URLs">
	Always show full URLs
	</message>
	</if>

correct me if i'm wrong ....

[deepxcode]

@deepxcode here we have a expr="not use_titlecase" for which we have the desired text casing and for expr="use_titlecase"... i think we must have capitalized format.. otherwise both are becoming the same essentially....

brave-core/app/generated_resources.grd

Lines 5226 to 5235 in 2d6b3a2

	<if expr="use_titlecase">
	<message name="IDS_CONTEXT_MENU_SHOW_FULL_URLS" desc="In Title Case: The text label of the omnibox context menu option to show full URLs">
	Always Show Full URLs
	</message>
	</if>
	<if expr="not use_titlecase">
	<message name="IDS_CONTEXT_MENU_SHOW_FULL_URLS" desc="The text label of the omnibox context menu option to show full URLs">
	Always show full URLs
	</message>
	</if>

correct me if i'm wrong ....

Yes, @swarup4741, You were right, made the requested changes

[swarup4741]

@deepxcode here we have a expr="not use_titlecase" for which we have the desired text casing and for expr="use_titlecase"... i think we must have capitalized format.. otherwise both are becoming the same essentially....

brave-core/app/generated_resources.grd

Lines 5226 to 5235 in 2d6b3a2

	<if expr="use_titlecase">
	<message name="IDS_CONTEXT_MENU_SHOW_FULL_URLS" desc="In Title Case: The text label of the omnibox context menu option to show full URLs">
	Always Show Full URLs
	</message>
	</if>
	<if expr="not use_titlecase">
	<message name="IDS_CONTEXT_MENU_SHOW_FULL_URLS" desc="The text label of the omnibox context menu option to show full URLs">
	Always show full URLs
	</message>
	</if>

correct me if i'm wrong ....

Yes, @swarup4741, You were right, made the requested changes

Then i think we don't require lines 5231 to 5235

[swarup4741]

since we have expr="not use_titlecase" then i think in desc we don't need "In Title Case"
The rest looks ok to me

[swarup4741]

It looks good 💪🏼 ... Now just squash all the commits into one

[swarup4741]

Looks fine with the changes

[bsclifton]

LGTM! 👍

[bsclifton]

@deepxcode can you please give this a rebase? Sorry that it took a while to review

[deepxcode]

@bsclifton I won't be able to give a rebase to it, ran out of storage space while installing brave's repo😅

[bsclifton]

@deepxcode ok no worries; I got you

[deepxcode]

Thanks, @bsclifton !