Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fixed sentence casing on Always Show Full URLs in brave://settings/appearance" #9970

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

simonhong
Copy link
Member

Reverts #9461

Reason: broken macOS build.

../../brave/chromium_src/chrome/browser/ui/cocoa/../../../../../../chrome/browser/ui/cocoa/main_menu_builder.mm:250:22: error: use of undeclared identifier 'IDS_CONTEXT_MENU_SHOW_FULL_URLS'
13:39:53                  Item(IDS_CONTEXT_MENU_SHOW_FULL_URLS)

@simonhong
Copy link
Member Author

We should not touch brave/app/genreated_resources.grd directly.
It's autogenerated from chrome/app/generated_resources.grd.

@linhkikuchi linhkikuchi self-requested a review September 3, 2021 05:30
@bsclifton
Copy link
Member

Dang - my bad here. Thanks for finding and correcting this @simonhong 😄

@simonhong simonhong added this to the 1.31.x - Nightly milestone Sep 3, 2021
@deepxcode
Copy link
Contributor

We should not touch brave/app/genreated_resources.grd directly.
It's autogenerated from chrome/app/generated_resources.grd.

@simonhong So in the future, if we need to make changes in Strings and correct them, in which file should we change the strings?

@simonhong
Copy link
Member Author

@deeppandya We are using https://github.com/brave/brave-core/blob/master/script/lib/grd_string_replacements.py when we want to update strings from upstream's grd files.
After adding some pairs for your fix, run npm run chromium_rebase_l10n.
Then, you can see updated grd files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants