-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Allow users to right click in brave://rewards-internals logs #9847
Fix: Allow users to right click in brave://rewards-internals logs #9847
Conversation
@suveshmoza this looks great! Two things:
After that, I think we're good 😄 I tested before and after the change. It's just removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment left 😄 Will re-review after that is addressed
Hey @bsclifton I did the things told by you above. Tell me if anything is wrong |
10f9b29
to
c80f882
Compare
@suveshmoza got it all squared away for you 😄 I ran a git rebase, squashed the commits (PR only has 1 commit now), and amended the commit log. You can check it out here: |
First time with rebasing. I think I'll have to get my hands dirty with rebasing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Heads up that this is causing CI tslint failures:
|
Resolves Fixes brave/brave-browser#16915
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: