Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow users to right click in brave://rewards-internals logs #9847

Merged

Conversation

suveshmoza
Copy link
Contributor

@suveshmoza suveshmoza commented Aug 25, 2021

Resolves Fixes brave/brave-browser#16915

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@suveshmoza suveshmoza requested a review from a team as a code owner August 25, 2021 05:44
@bsclifton
Copy link
Member

@suveshmoza this looks great! Two things:

  • Can you squash both commits? basically, you can do an interactive rebase (git rebase -i origin/master) and then pick s for the 2nd commit
  • Can you edit the commit message (not the top level message, but on the next line) to have the GitHub closing keywords? Basically the Fixes https://github.com/brave/brave-browser/issues/16915 (so it's in the commit message)

After that, I think we're good 😄 I tested before and after the change. It's just removing the e.preventDefault behavior that was added when the UI was created (with d833add)

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment left 😄 Will re-review after that is addressed

@suveshmoza suveshmoza changed the title Allow users to right click in brave rewards internal log Fixes https://github.com/brave/brave-browser/issues/16915 Aug 25, 2021
@suveshmoza suveshmoza changed the title Fixes https://github.com/brave/brave-browser/issues/16915 Fix: Allow users ot right click in brave://rewards-internals logs Aug 25, 2021
@suveshmoza suveshmoza changed the title Fix: Allow users ot right click in brave://rewards-internals logs Fix: Allow users to right click in brave://rewards-internals logs Aug 25, 2021
@suveshmoza
Copy link
Contributor Author

Hey @bsclifton I did the things told by you above. Tell me if anything is wrong

@bsclifton bsclifton force-pushed the right-click-in-brave-rewards-internal-log branch from 10f9b29 to c80f882 Compare August 25, 2021 16:12
@bsclifton
Copy link
Member

@suveshmoza got it all squared away for you 😄 I ran a git rebase, squashed the commits (PR only has 1 commit now), and amended the commit log. You can check it out here:
c80f882

@suveshmoza
Copy link
Contributor Author

@suveshmoza got it all squared away for you 😄 I ran a git rebase, squashed the commits (PR only has 1 commit now), and amended the commit log. You can check it out here:
c80f882

First time with rebasing. I think I'll have to get my hands dirty with rebasing.

@suveshmoza suveshmoza requested a review from bsclifton August 25, 2021 16:39
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit dcba5f9 into brave:master Aug 25, 2021
@bsclifton bsclifton added this to the 1.30.x - Nightly milestone Aug 25, 2021
@bbondy
Copy link
Member

bbondy commented Aug 25, 2021

Heads up that this is causing CI tslint failures:

ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:5:1 - Expected indentation of 0 spaces but found 1.
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:8:1 - Expected indentation of 0 spaces but found 1.
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:9:1 - Expected indentation of 0 spaces but found 1.
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:10:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:12:1 - Expected indentation of 0 spaces but found 1.
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:13:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:14:1 - Expected indentation of 0 spaces but found 1.
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:22:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:23:1 - Expected indentation of 0 spaces but found 1.
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:27:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:28:1 - Expected indentation of 0 spaces but found 1.
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:30:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:38:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:45:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:50:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:57:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:60:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:66:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:69:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:73:1 - trailing whitespace
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:79:5 - JSX attributes must be indented further than the opening tag statement
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:80:5 - JSX attributes must be indented further than the opening tag statement
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:81:5 - JSX attributes must be indented further than the opening tag statement
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:82:5 - JSX attributes must be indented further than the opening tag statement
ERROR: /users/bbondy/projects/brave/brave-browser/src/brave/components/brave_rewards/resources/internals/components/log.tsx:114:3 - file should end with a newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to right click in brave://rewards-internals logs
3 participants