Allow users to right click in brave://rewards-internals logs

[Miyayes]

Test plan

1. Launch Brave
2. Enable Rewards
3. Visit brave://rewards-internals
4. Go to Logs tab
5. Click Refresh
6. Select some log lines with the mouse
7. Right click
8. Verify regular context menu shows up (ex: copy, paste, etc) and that you can copy the line to the clipboard

Description

A user can highlight text in the rewards-internals logs but cannot right click (in order to open the mouse menu to copy). However, they can still use the CTRL or CMD + C shortcut to copy.

Some users are not as comfortable with keyboard shortcuts.

Solution

Enable right clicking in rewards-internals logs.

[deepxcode]

HI, I am ready to work on this issue, can you assign this to me? Also, can you tell me where I can locate the code?

[jonathansampson]

@deepxcode I believe you're looking for components/brave_rewards/resources/internals/components/log.tsx. Specifically, I suspect we may need only to remove the onContextMenu property from here:

<LogTextArea value={this.props.log} readOnly={true} onContextMenu={this.preventDefault}/>

[bsclifton]

@deepxcode assigned! You'll want to check out the file @jonathansampson shared - let us know if you run into any problems building the code (getting the browser compiling can definitely be a challenge itself 😄)

[deepxcode]

@bsclifton Do I need to clone brave-core too? And do I need to install chromium code too in my device?

[bsclifton]

@deeppandya when you clone brave-browser and run npm run init, it'll download all of that (brave-core and Chromium) for you 😄

Instructions here https://github.com/brave/brave-browser#install-prerequisites

[deepxcode]

Oh okay, Thanks @bsclifton! Also, you mentioned the wrong user😅, My user name is @deepxcode.
Also, will it run fine on my laptop? Like I have a laptop with 8Gb ram, i5 8th gen, 128Gb SSD, and 1TB hard disk? or I have to upgrade my laptop?

[bsclifton]

Apologies @deepxcode - @deeppandya is my teammate Deep; GitHub kept auto-picking his ID from the dropdown 😄

Your hardware spec sounds OK! The build will use a decent amount of disk space and it'll take a while to build actually (maybe 6 or 7 hours for the first build). Incremental builds after that are quick. Please give it a go- let us know how things go

[deepxcode]

Oh okay😅
@bsclifton, I am facing this error, first was facing with SSH key, I resolved that. But now, when I am running npm run init it shows the below error

[deeppandya]

@deepxcode try to delete everything inside brave_browser folder. And clone the repo again. When npm run init fails, you would see this error as it would keep stale copy of few items.

[deepxcode]

I tried this, but I am getting the same error again and again.
I was cloning the repository at C:/ as mentioned in the doc, but it is not working. I even tried to clone the repository in another directory but receiving the same error

[deeppandya]

@deepxcode did you follow the instructions here : https://github.com/brave/brave-browser/wiki/Linux-Development-Environment ?

[deepxcode]

No, I have a Windows device so I followed this documentation :- https://github.com/brave/brave-browser/wiki/Windows-Development-Environment
I installed Visual Studio Latest version, Windows SDK, Python 2.7 (latest version) and Node.

[deepxcode]

Update: I am able to resolve the error now. The error was thrown because I had a different version of npm installed. I reverted npm to an older version and now everything is downloading. Thanks to @bsclifton and this issue #13631.

[deepxcode]

@bsclifton Is it necessary to clone the repository in C:/. Yesterday, I was installing the software and in the end, I just ran out of C Drive storage. So asking that, if it's alright to clone the repository in another drive?

[suveshmoza]

Can I work on this issue?

[deepxcode]

Sure, you can! I will just unassign the issue to me.

[suveshmoza]

@bsclifton Getting this error after running npm run init

OS:Ubuntu 20.04
NodeJS: 14.17.5
NPM:6.14.14

[deepxcode]

@suveshmoza, I too faced the same error but on windows. I reverted back my npm to an older version like 6.14.11 and the issue was resolved.

[suveshmoza]

Thanks @deepxcode but adding --scripts-prepend-node-path solved the issue for me.

[bsclifton]

Hi folks - apologies for missing all the convo here; thanks for the PR, @suveshmoza 😄 Will check this out

[stephendonner]

Verified PASSED using

Brave	1.30.56 Chromium: 93.0.4577.58 (Official Build) beta (x86_64)
Revision	c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS	macOS Version 11.5.2 (Build 20G95)

Steps:

1. New profile
2. Launched Brave
3. Enabled Rewards
4. Visited brave://rewards-internals
5. Went to Logs tab
6. Clicked Refresh
7. Selected some log lines with the mouse
8. Right clicked
9. Verified regular context menu shows up (ex: copy, paste, etc) and that you can copy the line to the clipboard

example	example

---

Verification passed on

Brave | 1.30.59 Chromium: 93.0.4577.58 (Official Build) beta (64-bit)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

• Verified the STR from the description

example	example