-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #17692 - Add messaging in the UI about 5% tipping fee when tipping #9867
Conversation
@@ -639,7 +639,7 @@ | |||
<message name="IDS_BRAVE_REWARDS_ONBOARDING_SETUP_CONTRIBUTE_SUBHEADER" desc="">(from your ads earnings)</message> | |||
<message name="IDS_BRAVE_REWARDS_ONBOARDING_START_USING_REWARDS" desc="">Start using Brave Rewards</message> | |||
<message name="IDS_BRAVE_REWARDS_ONBOARDING_TAKE_TOUR" desc="">Take a quick tour</message> | |||
<message name="IDS_BRAVE_REWARDS_ONBOARDING_TERMS" desc="">By proceeding, you agree to the <ph name="TOS_LINK_BEGIN">$1</ph>Terms of Service<ph name="TOS_LINK_END">$2</ph> and <ph name="PP_LINK_BEGIN">$3</ph>Privacy Policy<ph name="PP_LINK_END">$4</ph>.</message> | |||
<message name="IDS_BRAVE_REWARDS_ONBOARDING_TERMS" desc="">Brave collects 5% of the tip amount as a processing fee. By proceeding, you agree to the <ph name="TOS_LINK_BEGIN">$1</ph>Terms of Service<ph name="TOS_LINK_END">$2</ph> and <ph name="PP_LINK_BEGIN">$3</ph>Privacy Policy<ph name="PP_LINK_END">$4</ph>.</message> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I think this will update the terms of service text for all Rewards onboarding components. Also, I think we only want to show this message for users with a verified external wallet. We'll probably need to add a component to the tip application for this specific case.
@@ -968,6 +968,7 @@ void CustomizeWebUIHTMLSource(const std::string &name, | |||
{ "monthlyText", IDS_BRAVE_UI_MONTHLY_TEXT }, | |||
{ "nextContributionDate", IDS_BRAVE_REWARDS_TIP_NEXT_CONTRIBUTION_DATE }, // NOLINT | |||
{ "notEnoughTokens", IDS_BRAVE_REWARDS_TIP_NOT_ENOUGH_TOKENS }, | |||
{ "tipNote", IDS_BRAVE_REWARDS_TIP_NOTE }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this a little more self-documenting, let's name this string "tippingFeeNote" / IDS_BRAVE_REWARDS_TIPPING_FEE_NOTE
.
Also, let's add a "tippingFeeNote" entry to tip/stories/locale_strings.ts
for storybook.
@@ -160,6 +161,7 @@ export function BatTipForm (props: Props) { | |||
</style.main> | |||
<style.footer> | |||
<style.terms> | |||
<TipNote /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this component is just wrapping a string with styles, then we can get away with not defining a new component, and we can just use the string directly:
<style.terms>
<style.feeNote>
{getString('tippingFeeNote')}
</style.feeNote>
<TermsOfService />
</style.terms>
Verification PASSED on
|
Resolves brave/brave-browser#17692
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: