Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new rewards strings added to tipping banner are missing translations #17761

Closed
LaurenWags opened this issue Aug 30, 2021 · 1 comment · Fixed by brave/brave-core#9942
Closed

Comments

@LaurenWags
Copy link
Member

Description

New strings were added to the tipping banner with brave/brave-core#9867 and brave/brave-core#9873.

These strings were added after the translation order for 1.29.x was placed, we will need to ensure that these strings get translated and added to the browser.

Steps to Reproduce

  1. Use 1.29.x with a language other than English
  2. Enable Rewards
  3. Navigate to a site, and open tipping banner

Actual result:

New strings are not translated:

Example Example
スクリーンショット 2021-08-30 10 50 10 bF - dlipeles on GH - 1time

Expected result:

New strings should be translated

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.29.75 Chromium: 93.0.4577.58 (Official Build) (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 10.15.7 (Build 19H1323)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.28.x n/a, 1.29.x yes
  • Can you reproduce this issue with the beta channel? 1.30.x yes
  • Can you reproduce this issue with the nightly channel? 1.31.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/legacy_qa @Miyayes @rebron

@LaurenWags
Copy link
Member Author

LaurenWags commented Sep 2, 2021

Verified passed with

Brave | 1.29.77 Chromium: 93.0.4577.63 (Official Build) (x86_64)
-- | --
変更履歴 | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | macOS バージョン10.15.7(ビルド19H1323)

Verified STR for the languages below:

French

Example Example
French French2

German

Example Example
German German2

Japanese

Example Example
スクリーンショット 2021-09-02 9 08 31 スクリーンショット 2021-09-02 9 08 40

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.29.77 Chromium: 93.0.4577.63 (Official Build) (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19042.1165)

Polish

Example Example
polish5 polishMinute

Chinese

Example Example
5 1

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment