Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17700 - Add messaging in tipping flow to tell users that tips could take a few minutes to process #9873

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Aug 26, 2021

Resolves brave/brave-browser#17700

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Tip a verified creator
  2. Verify the Note: Your tip can take several minutes to process is visible

Screen Shot 2021-08-27 at 12 31 53 PM

@jumde jumde requested a review from a team as a code owner August 26, 2021 19:25
@jumde jumde self-assigned this Aug 26, 2021
@jumde jumde requested review from bsclifton and emerick August 26, 2021 19:25
@jumde jumde requested a review from zenparsing August 27, 2021 17:35
@kjozwiak
Copy link
Member

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.31.5 Chromium: 93.0.4577.58 (Official Build) nightly (64-bit)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Windows 10 OS Version 2009 (Build 19042.1165)
Verified Unverified
verified unverified

Created brave/brave-browser#17756 as a follow up as we shouldn't be displaying the Note: Your tip can take several minutes to process message when a user sets up a monthly contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add messaging in tipping flow to tell users that tips could take a few minutes to process
5 participants