Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloaded the latest l10n for 1.29.x. (uplift to 1.29.x) #9955

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Downloaded the latest l10n for 1.29.x. (uplift to 1.29.x) #9955

merged 1 commit into from
Sep 2, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 2, 2021 •
edited by kjozwiak
Loading

Fixes brave/brave-browser#17761
Uplift of #9942

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 2, 2021 00:49
@brave-builds brave-builds requested review from deeppandya, zenparsing and a team and removed request for a team September 2, 2021 00:49
@brave-builds brave-builds self-assigned this Sep 2, 2021
@brave-builds brave-builds added this to the 1.29.x - Release milestone Sep 2, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Sep 2, 2021

Restarting macOS as build failed as per https://ci.brave.com/job/pr-brave-browser-pr9942_maxk-1.29.x-adtl-l10n_1.29.x-macos/1/execution/node/139/log/.

 FAILED: obj/brave/browser/ui/bookmark/bookmark/brave_bookmark_tab_helper.o

kjozwiak
kjozwiak approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.29.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 854eec8 into 1.29.x Sep 2, 2021
@kjozwiak kjozwiak deleted the pr9942_maxk-1.29.x-adtl-l10n_1.29.x branch September 2, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@deeppandya deeppandya Awaiting requested review from deeppandya

@zenparsing zenparsing Awaiting requested review from zenparsing

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.29.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases