This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Handle no active tab in state and no cosmetic filter list in storage #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix brave/brave-browser#845 Fix brave/brave-browser#846 [state].GetActiveTabData can return undefined from state yet the type did not reflect this even though some calls, but not all calls, handled it. cosemtic filter list was being read before it was set in storage.
Snuupy
approved these changes
Aug 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#845
Fix brave/brave-browser#846
[state].GetActiveTabData can return undefined from state yet the type did not reflect this even though some calls, but not all calls, handled it.
cosemtic filter list was being read before it was set in storage.