Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave extension error: Cannot read property 'hostname' of undefined #845

Closed
petemill opened this issue Aug 27, 2018 · 0 comments
Closed

Brave extension error: Cannot read property 'hostname' of undefined #845

petemill opened this issue Aug 27, 2018 · 0 comments
Assignees
@petemill
Labels
feature/shields The overall Shields feature in Brave. QA/No
Milestone
0.55.x - Release ...

Comments

@petemill
Copy link
Member

Latest master of brave-extension (21d8bd92e402d35ed3a71a6f8262da6f1d9c9aa4) can get in to a state where it will not load properly on any tab. This is because the signature of getActiveTab from state is not correct - it can return undefined yet that is not handled everywhere.

Error in event handler: TypeError: Cannot read property 'hostname' of undefined
    at t.default (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:132464)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4089
    at v (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:2006)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:126300
    at Object.onCommitted (chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:4216)
    at chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/js/background.bundle.js:1:138529
@petemill petemill added this to the Releasable builds 0.55.x milestone Aug 27, 2018
@petemill petemill self-assigned this Aug 27, 2018
@petemill petemill added the feature/shields The overall Shields feature in Brave. label Aug 27, 2018
petemill added a commit to petemill/brave-extension that referenced this issue Aug 27, 2018
@petemill
Handle no active tab in state and no cosmetic filter list in storage
cf068d4 
Fix brave/brave-browser#845
Fix brave/brave-browser#846

[state].GetActiveTabData can return undefined from state yet the type did not reflect this even though some calls, but not all calls, handled it.

cosemtic filter list was being read before it was set in storage.
@petemill petemill mentioned this issue Aug 27, 2018
Merged
@bbondy bbondy added the QA/No label Sep 10, 2018
This was referenced Sep 14, 2021
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 15, 2021
Closed
This was referenced Sep 15, 2021
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 16, 2021
Closed
@stephendonner stephendonner mentioned this issue Sep 16, 2021
Closed
This was referenced Sep 16, 2021
Closed
Closed
@stephendonner stephendonner mentioned this issue Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/shields The overall Shields feature in Brave. QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
2 participants
@petemill @bbondy