Disable new tab background for tests

Auditors: @bsclifton Fix: #9240
brave · Jun 15, 2017 · 4dae74f · 4dae74f
1 parent 6478bcd
commit 4dae74f
Show file tree

Hide file tree

Showing 40 changed files with 55 additions and 0 deletions.
diff --git a/test/about/adblockTest.js b/test/about/adblockTest.js
@@ -9,6 +9,7 @@ describe('about:adblock', function () {
   before(function * () {
     const url = getTargetAboutUrl('about:adblock')
     yield this.app.client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/about/bookmarksManagerTest.js b/test/about/bookmarksManagerTest.js
@@ -16,6 +16,7 @@ describe('about:bookmarks', function () {
 
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/about/braveTest.js b/test/about/braveTest.js
@@ -9,6 +9,7 @@ describe('about:brave tests', function () {
   before(function * () {
     const url = getTargetAboutUrl('about:brave')
     yield this.app.client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/about/componentUpdaterTest.js b/test/about/componentUpdaterTest.js
@@ -7,6 +7,7 @@ const appConfig = require('../../js/constants/appConfig')
 describe('component updater', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/about/extensionsTest.js b/test/about/extensionsTest.js
@@ -11,6 +11,7 @@ const extensionDownloadWaitTime = 30000
 describe('about:extensions', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/about/historyTest.js b/test/about/historyTest.js
@@ -11,6 +11,7 @@ describe('about:history', function () {
 
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/about/ledgerPanelAdvancedPanelTest.js b/test/about/ledgerPanelAdvancedPanelTest.js
@@ -25,6 +25,7 @@ let translationsCache = null
 
 function setup (client) {
   return client
+    .changeSetting('tabs.show-dashboard-images', false)
     .waitForBrowserWindow()
     .waitForVisible(urlInput)
     .translations().then(function (translations) {

diff --git a/test/about/ledgerPanelTest.js b/test/about/ledgerPanelTest.js
@@ -27,6 +27,7 @@ function * setupBrave () {
 
 function * setup (client) {
   yield client
+    .changeSetting('tabs.show-dashboard-images', false)
     .waitForUrl(Brave.newTabUrl)
     .waitForBrowserWindow()
     .waitForVisible(urlInput)

diff --git a/test/about/ledgerTableTest.js b/test/about/ledgerTableTest.js
@@ -35,6 +35,7 @@ const secondTableForthRow = `${secondTable} [data-row-index="3"]`
 
 function * setup (client) {
   yield client
+    .changeSetting('tabs.show-dashboard-images', false)
     .waitForUrl(Brave.newTabUrl)
     .waitForBrowserWindow()
     .waitForVisible(urlInput)

diff --git a/test/about/newTabTest.js b/test/about/newTabTest.js
@@ -10,6 +10,7 @@ const aboutNewTabUrl = getTargetAboutUrl('about:newtab')
 describe('about:newtab tests', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/about/preferencesTest.js b/test/about/preferencesTest.js
@@ -10,6 +10,7 @@ const prefsShieldsUrl = 'about:preferences#shields'
 
 function * setup (client) {
   yield client
+    .changeSetting('tabs.show-dashboard-images', false)
     .waitForUrl(Brave.newTabUrl)
     .waitForBrowserWindow()
     .waitForVisible(urlInput)

diff --git a/test/about/stylesTest.js b/test/about/stylesTest.js
@@ -9,6 +9,7 @@ describe('about:styles', function () {
   before(function * () {
     const url = getTargetAboutUrl('about:styles')
     yield this.app.client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/app/renderer/components/messageBoxTest.js b/test/app/renderer/components/messageBoxTest.js
@@ -29,6 +29,7 @@ let alertText
 describe('MessageBox component tests', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForEnabled(urlInput)

diff --git a/test/app/sessionStoreTest.js b/test/app/sessionStoreTest.js
@@ -23,6 +23,7 @@ describe('sessionStore', function () {
       yield Brave.startApp()
       yield setup(Brave.app.client)
       yield Brave.app.client
+        .changeSetting('tabs.show-dashboard-images', false)
         .waitForBrowserWindow()
         .onClearBrowsingData({browserHistory: true})
         .waitForUrl(Brave.newTabUrl)

diff --git a/test/bookmark-components/bookmarksTest.js b/test/bookmark-components/bookmarksTest.js
@@ -8,6 +8,7 @@ const siteTags = require('../../js/constants/siteTags')
 describe('bookmark tests', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForEnabled(urlInput)

diff --git a/test/bookmark-components/bookmarksToolbarTest.js b/test/bookmark-components/bookmarksToolbarTest.js
@@ -7,6 +7,7 @@ const siteTags = require('../../js/constants/siteTags')
 
 function * setup (client) {
   yield client
+    .changeSetting('tabs.show-dashboard-images', false)
     .waitForUrl(Brave.newTabUrl)
     .waitForBrowserWindow()
     .waitForEnabled(urlInput)

diff --git a/test/bravery-components/braveryPanelTest.js b/test/bravery-components/braveryPanelTest.js
@@ -28,6 +28,7 @@ const settings = require('../../js/constants/settings')
 describe('Bravery Panel', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/bravery-components/clearBrowsingDataPanelTest.js b/test/bravery-components/clearBrowsingDataPanelTest.js
@@ -11,6 +11,7 @@ const siteSettingsList = require('../../js/data/siteSettingsList')
 describe('Clear Browsing Panel', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/bravery-components/flashTest.js b/test/bravery-components/flashTest.js
@@ -6,6 +6,7 @@ const {notificationBar, urlInput} = require('../lib/selectors')
 describe('flash install interception', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)
       .changeSetting('security.flash.installed', true)

diff --git a/test/bravery-components/noScriptTest.js b/test/bravery-components/noScriptTest.js
@@ -9,6 +9,7 @@ const result = '#result'
 
 function * setup (client) {
   yield client
+    .changeSetting('tabs.show-dashboard-images', false)
     .waitForUrl(Brave.newTabUrl)
     .waitForBrowserWindow()
     .waitForVisible(urlInput)

diff --git a/test/bravery-components/notificationBarTest.js b/test/bravery-components/notificationBarTest.js
@@ -8,6 +8,7 @@ const {AUTOPLAY_MEDIA} = require('../../js/constants/settings')
 describe('notificationBar permissions', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)
       .changeSetting('general.disable-title-mode', false)

diff --git a/test/bravery-components/safebrowsingTest.js b/test/bravery-components/safebrowsingTest.js
@@ -12,6 +12,7 @@ const link = '#clickme'
 describe('safebrowsing interception', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)
   }

diff --git a/test/contents/autofillTest.js b/test/contents/autofillTest.js
@@ -44,6 +44,7 @@ const formCreditYearInput = '[name="43ccexp_yy"]'
 describe('Autofill', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/contents/contentLoadingTest.js b/test/contents/contentLoadingTest.js
@@ -6,6 +6,7 @@ const {urlInput} = require('../lib/selectors')
 describe('content loading', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/contents/errorPageTest.js b/test/contents/errorPageTest.js
@@ -9,6 +9,7 @@ describe('errorPage', function () {
 
   beforeEach(function * () {
     yield this.app.client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)
   })

diff --git a/test/misc-components/contextMenuTest.js b/test/misc-components/contextMenuTest.js
@@ -6,6 +6,7 @@ const {urlInput} = require('../lib/selectors')
 describe('ContextMenu', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForEnabled(urlInput)

diff --git a/test/misc-components/downloadItemTest.js b/test/misc-components/downloadItemTest.js
@@ -19,6 +19,7 @@ const {
 
 function * setup (client) {
   yield client
+    .changeSetting('tabs.show-dashboard-images', false)
     .waitForUrl(Brave.newTabUrl)
     .waitForBrowserWindow()
     .waitForVisible(urlInput)

diff --git a/test/misc-components/findbarTest.js b/test/misc-components/findbarTest.js
@@ -9,6 +9,7 @@ describe('findBar', function () {
     yield setup(this.app.client)
     const url = Brave.server.url('find_in_page.html')
     yield this.app.client
+      .changeSetting('tabs.show-dashboard-images', false)
       .changeSetting('general.disable-title-mode', false)
       .tabByIndex(0)
       .url(url)

diff --git a/test/misc-components/syncTest.js b/test/misc-components/syncTest.js
@@ -49,6 +49,7 @@ const checkSiteSetting = function (hostPattern, setting, value) {
 function * setupBrave (client) {
   Brave.addCommands()
   yield client
+    .changeSetting('tabs.show-dashboard-images', false)
     .waitForUrl(Brave.newTabUrl)
     .waitForBrowserWindow()
 }

diff --git a/test/misc-components/windowTest.js b/test/misc-components/windowTest.js
@@ -10,6 +10,7 @@ describe('application window', function () {
 
     it('opens a window and loads the UI', function * () {
       yield this.app.client
+        .changeSetting('tabs.show-dashboard-images', false)
         .waitForUrl(Brave.newTabUrl)
         .waitForBrowserWindow()
         .windowByIndex(0)
@@ -44,6 +45,7 @@ describe('application window', function () {
 
       before(function * () {
         yield this.app.client
+          .changeSetting('tabs.show-dashboard-images', false)
           .waitForUrl(Brave.newTabUrl)
           .waitForBrowserWindow()
           .windowByIndex(0)
@@ -158,6 +160,7 @@ describe('application window', function () {
 
       before(function * () {
         yield this.app.client
+          .changeSetting('tabs.show-dashboard-images', false)
           .waitForUrl(Brave.newTabUrl)
           .waitForBrowserWindow()
           .resizeWindow(600, 700)
@@ -206,6 +209,7 @@ describe('application window', function () {
         this.page1 = Brave.server.url('page1.html')
 
         yield this.app.client
+          .changeSetting('tabs.show-dashboard-images', false)
           .waitForBrowserWindow()
           .waitForUrl(Brave.newTabUrl)
           .loadUrl(Brave.server.url('window_open.html'))
@@ -327,6 +331,7 @@ describe('application window', function () {
         this.page1 = Brave.server.urlWithIpAddress('page1.html')
 
         yield this.app.client
+          .changeSetting('tabs.show-dashboard-images', false)
           .waitForBrowserWindow()
           .waitForUrl(Brave.newTabUrl)
           .loadUrl(this.window_open_page)
@@ -530,6 +535,7 @@ describe('application window', function () {
       this.page1 = Brave.server.urlWithIpAddress('page1.html')
 
       yield this.app.client
+        .changeSetting('tabs.show-dashboard-images', false)
         .waitForUrl(Brave.newTabUrl)
         .waitForBrowserWindow()
         .waitForVisible(activeWebview)
@@ -566,6 +572,7 @@ describe('application window', function () {
         var page1 = Brave.server.url('page1.html')
 
         yield this.app.client
+          .changeSetting('tabs.show-dashboard-images', false)
           .waitForUrl(Brave.newTabUrl)
           .waitForBrowserWindow()
           .waitForVisible(activeWebview)
@@ -608,6 +615,7 @@ describe('application window', function () {
         this.page2 = Brave.server.url('page2.html')
 
         yield this.app.client
+          .changeSetting('tabs.show-dashboard-images', false)
           .waitForBrowserWindow()
           .waitForUrl(Brave.newTabUrl)
           .loadUrl(this.clickWithTargetPage)
@@ -767,6 +775,7 @@ describe('application window', function () {
       this.page1 = Brave.server.url('close.html')
 
       yield this.app.client
+        .changeSetting('tabs.show-dashboard-images', false)
         .waitForBrowserWindow()
         .waitForUrl(Brave.newTabUrl)
         .loadUrl(this.page1)

diff --git a/test/navbar-components/navigationBarTest.js b/test/navbar-components/navigationBarTest.js
@@ -15,6 +15,7 @@ const messages = require('../../js/constants/messages')
 describe('navigationBar tests', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .windowByUrl(Brave.browserWindowUrl)
       .waitForEnabled(urlInput)

diff --git a/test/navbar-components/navigatorTest.js b/test/navbar-components/navigatorTest.js
@@ -6,6 +6,7 @@ const {urlInput, braveMenu, braveryPanel, braveryPanelContainer} = require('../l
 describe('navigator component tests', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/navbar-components/siteInfoTest.js b/test/navbar-components/siteInfoTest.js
@@ -10,6 +10,7 @@ const {urlInput, urlbarIcon, siteInfoDialog, viewCertificateButton} = require('.
 describe('siteInfo component tests', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/navbar-components/urlBarSuggestionsTest.js b/test/navbar-components/urlBarSuggestionsTest.js
@@ -9,6 +9,7 @@ const aboutHistoryState = require('../../app/common/state/aboutHistoryState')
 describe('urlBarSuggestions', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForVisible(urlInput)

diff --git a/test/navbar-components/urlBarTest.js b/test/navbar-components/urlBarTest.js
@@ -9,6 +9,7 @@ const config = require('../../js/constants/config')
 describe('urlBar tests', function () {
   function * setup (client) {
     yield client
+      .changeSetting('tabs.show-dashboard-images', false)
       .waitForUrl(Brave.newTabUrl)
       .waitForBrowserWindow()
       .waitForEnabled(urlInput)