Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disable fetching background images on test runs #9240

Closed
luixxiul opened this issue Jun 3, 2017 · 0 comments
Closed

Disable fetching background images on test runs #9240

luixxiul opened this issue Jun 3, 2017 · 0 comments
Assignees
@cezaraugusto
Labels
automated-tests QA/checked release-notes/exclude suggestion
Milestone
0.19.x (Beta Chan...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jun 3, 2017 •
edited by cezaraugusto
Loading

Describe the issue you encountered: Create an option to disable fetching background images on test runs.

#6503 (comment)

I notice npm run test often fails due to timeout because images are not fetched in time.

Per @bsclifton;

another option: we could default that setting to false if NODE_ENV is test
@luixxiul luixxiul mentioned this issue Jun 3, 2017
Closed
@cezaraugusto cezaraugusto self-assigned this Jun 9, 2017
cezaraugusto added a commit that referenced this issue Jun 15, 2017
@cezaraugusto
Disable new tab background for tests
4dae74f 
Auditors: @bsclifton
Fix: #9240
@cezaraugusto cezaraugusto changed the title Create an option to disable fetching background images on test runs Disable fetching background images on test runs Jun 15, 2017
@cezaraugusto cezaraugusto mentioned this issue Jun 15, 2017
Merged
8 tasks
cezaraugusto added a commit that referenced this issue Jun 19, 2017
@cezaraugusto
Disable new tab background for tests
b96f0b1 
Close #9240
@luixxiul luixxiul added this to the 0.19.x (Nightly Channel) milestone Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
automated-tests QA/checked release-notes/exclude suggestion
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
2 participants
@luixxiul @cezaraugusto