Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
fix #8374 - Open image in new tab should recognize focus prefs
Browse files Browse the repository at this point in the history
It causes a crash on linux

FYI: @bridiver
  • Loading branch information
bbondy authored and jamesmudgett committed Apr 26, 2017
1 parent 576921b commit 687bfc3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion js/contextMenus.js
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,7 @@ function mainTemplateInit (nodeProps, frame, tab) {
}

if (isImage) {
const active = getSetting(settings.SWITCH_TO_NEW_TABS) === true
template.push(
{
label: locale.translation('openImageInNewTab'),
Expand All @@ -1035,7 +1036,8 @@ function mainTemplateInit (nodeProps, frame, tab) {
appActions.createTabRequested({
url: nodeProps.srcURL,
openerTabId: frame.get('tabId'),
partition: getPartitionFromNumber(frame.get('partitionNumber'), isPrivate)
partition: getPartitionFromNumber(frame.get('partitionNumber'), isPrivate),
active: active
})
}
}
Expand Down
2 changes: 1 addition & 1 deletion test/lib/brave.js
Original file line number Diff line number Diff line change
Expand Up @@ -970,7 +970,7 @@ var exports = {
? 'node_modules/electron-prebuilt/dist/brave.exe'
: './node_modules/.bin/electron',
env,
args: ['./', '--debug=5858', '--enable-logging', '--v=1'],
args: ['./', '--enable-logging', '--v=1'],
requireName: 'devTools'
})
return this.app.start()
Expand Down

0 comments on commit 687bfc3

Please sign in to comment.