Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Inconsistent 'open in tab' behaviour #8374

Closed
darvids0n opened this issue Apr 18, 2017 · 0 comments
Closed

Inconsistent 'open in tab' behaviour #8374

darvids0n opened this issue Apr 18, 2017 · 0 comments

Comments

@darvids0n
Copy link

darvids0n commented Apr 18, 2017

Test plan

#8509 (comment)

  1. In Preferences > Tabs, set "Switch to new tabs immediately" to false
  2. Visit a site with images (ex: cnn.com)
  3. Right click an image and pick "Open Image in New Tab"
  4. Image should open in new tab- but focus is not sent
  5. Toggle the setting (set in step 1)
  6. Right click an image and pick "Open Image in New Tab"
  7. Focus should be given immediately to the new tab

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Currently, Open Image in New Tab switches to the tab, but Open Link in New Tab doesn't. If I unset Switch to new tabs immediately, my expectation is that it will be honoured for all new tabs.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS 10.12.3

  • Brave Version (revision SHA):
    0.14.1 (3de60d5)

  • Steps to reproduce:

    1. Disable 'Switch to new tabs immediately' in Settings/Tabs
    2. Right-click an image and Open Image in New Tab
  • Actual result:
    Tab switch occurs immediately

  • Expected result:
    Tab switch should not occur

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.