Merge pull request #9360 from bsclifton/fix-tab-focus

Don't activate tab on right click
brave · Jun 13, 2017 · ab2cc4e · ab2cc4e
1 parent 2b2286f
commit ab2cc4e
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/app/renderer/components/tabs/tab.js b/app/renderer/components/tabs/tab.js
@@ -170,11 +170,17 @@ class Tab extends React.Component {
   }
 
   onClickTab (e) {
-    if (e.button === 1) {
-      this.onTabClosedWithMouse(e)
-    } else {
-      e.stopPropagation()
-      appActions.tabActivateRequested(this.props.tabId)
+    switch (e.button) {
+      case 2:
+        // Ignore right click
+        return
+      case 1:
+        // Close tab with middle click
+        this.onTabClosedWithMouse(e)
+        break
+      default:
+        e.stopPropagation()
+        appActions.tabActivateRequested(this.props.tabId)
     }
   }