Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Don't activate tab on right click #9360

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Don't activate tab on right click #9360

merged 1 commit into from
Jun 13, 2017

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jun 9, 2017

Test plan

  1. Open two tabs. Set focus to tab 2
  2. Right click tab 1 and verify context menu appears
  3. Press ESC (if your keyboard has it 🤣 )
  4. verify menu closes and focus did NOT change
  5. Right click tab 1 so that context menu appears
  6. Right click another place in tab 1 so that the context menu closes then reopens
  7. Verify focus did NOT change
  8. Push ESC and verify menu closes / focus did not change

Description

Fixes #7327

Auditors: @NejcZdovc, @cezaraugusto

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added bug feature/tabsbar polish Nice to have — usually related to front-end/visual tasks. labels Jun 9, 2017
@bsclifton bsclifton added this to the 0.17.x (Frozen, only critical adds from here) milestone Jun 9, 2017
@bsclifton bsclifton self-assigned this Jun 9, 2017
@bbondy
Copy link
Member

bbondy commented Jun 13, 2017

Would be good to get a test for right click on tab doesn't cause active tab switch, but I'll pull this in.

@bbondy bbondy merged commit 8304ad7 into brave:master Jun 13, 2017
bbondy added a commit that referenced this pull request Jun 13, 2017
Don't activate tab on right click
bbondy added a commit that referenced this pull request Jun 13, 2017
Don't activate tab on right click
@bsclifton bsclifton deleted the fix-tab-focus branch June 16, 2017 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/tabsbar polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right clicking tab being previewed causes focus to change
2 participants