This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Drag padlock to add bookmark doesn't show bookmarked icon #11033
Assignees
Labels
Milestone
Comments
bbondy
added a commit
that referenced
this issue
Sep 21, 2017
Fix #11033 We currently don't have DND under automated so no extra test coverage. The js/dnd change is if you drag a bookmark from Chrome to Brave it was erroring with a JS error before instead of creating the bookmark. Now it works. Auditors: @cezaraugusto
bbondy
added a commit
that referenced
this issue
Sep 21, 2017
Fix #11033 We currently don't have DND under automated so no extra test coverage. The js/dnd change is if you drag a bookmark from Chrome to Brave it was erroring with a JS error before instead of creating the bookmark. Now it works. Auditors: @cezaraugusto
This was referenced Sep 22, 2017
This was referenced Sep 25, 2017
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Fix brave#11033 We currently don't have DND under automated so no extra test coverage. The js/dnd change is if you drag a bookmark from Chrome to Brave it was erroring with a JS error before instead of creating the bookmark. Now it works. This is a subset of a larger change that we needed for 0.18.x and 0.19.x only. Those changesets are: 582224d 48fee97 Auditors: @cezaraugusto
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Drag padlock to add bookmark doesn't show bookmarked icon
Steps to Reproduce
Actual result:
Expected result:
Should add bookmark and show the bookmarked icon
Reproduces how often: [What percentage of the time does it reproduce?]
100% regression
Brave Version
Additional Information
Visiting the site in a new tab shows the bookmarked icon on both the tabs
#9753
The text was updated successfully, but these errors were encountered: