Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

error when dismissing notification bar for window crashes #11810

Closed
petemill opened this issue Nov 6, 2017 · 0 comments
Closed

error when dismissing notification bar for window crashes #11810

petemill opened this issue Nov 6, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
QA/no-qa-needed regression release-notes/exclude
Milestone
0.19.x Hotfix 4 (...

Comments

@petemill
Copy link
Member

petemill commented Nov 6, 2017

Description

When causing a window crash, and opening a new window, a notification bar is shown stating 'An unexpected error has occurred and the window has been reloaded'. Clicking OK results in the console error:

TypeError: appActions.hideMessageBox is not a function
    at EventEmitter.notificationResponseCallback (/Users/petemill/Development/Brave/browser-laptop/app/browser/windows.js:172:26)
    at emitMany (events.js:132:20)
    at EventEmitter.emit (events.js:204:7)
    at WebContents.<anonymous> (/Users/petemill/Development/Brave/browser-laptop/node_modules/electron-prebuilt/dist/Brave.app/Contents/Resources/electron.asar/browser/api/web-contents.js:184:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:194:7)

Similar to the issue reported and fixed in #2617, looks like that introduced a code path which is not working now.

Brave Version

about:brave info:

Brave: 0.21.0
V8: 6.2.414.36
rev: master
Muon: 4.5.13
OS Release: 17.2.0
Update Channel:
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 62.0.3202.75
@petemill petemill added this to the Triage Backlog milestone Nov 6, 2017
@NejcZdovc NejcZdovc self-assigned this Nov 7, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Nov 8, 2017
@NejcZdovc
Replaces missing appAction
6d1e5fb 
Resolves brave#11810

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Nov 8, 2017
Merged
8 tasks
bbondy added a commit that referenced this issue Nov 8, 2017
@bbondy
Merge pull request #11836 from NejcZdovc/hotfix/#11810-notification
c840798 
Replaces missing appAction
bbondy added a commit that referenced this issue Nov 8, 2017
@bbondy
Merge pull request #11836 from NejcZdovc/hotfix/#11810-notification
3a19e4c 
Replaces missing appAction
bbondy added a commit that referenced this issue Nov 8, 2017
@bbondy
Merge pull request #11836 from NejcZdovc/hotfix/#11810-notification
22b1d8c 
Replaces missing appAction
bbondy added a commit that referenced this issue Nov 8, 2017
@bbondy
Merge pull request #11836 from NejcZdovc/hotfix/#11810-notification
1bd705b 
Replaces missing appAction
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Replaces missing appAction
d19cb61 
Resolves brave#11810

Auditors:

Test Plan:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
QA/no-qa-needed regression release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 4 (Release channel)
Development

No branches or pull requests
4 participants
@petemill @luixxiul @bsclifton @NejcZdovc