Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replaces missing appAction #11836

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Nov 8, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #11810

Auditors:

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#11810

Auditors:

Test Plan:
@bbondy bbondy merged commit c840798 into brave:master Nov 8, 2017
bbondy added a commit that referenced this pull request Nov 8, 2017
bbondy added a commit that referenced this pull request Nov 8, 2017
bbondy added a commit that referenced this pull request Nov 8, 2017
@bbondy
Copy link
Member

bbondy commented Nov 8, 2017

master: c840798
0.21.x: 3a19e4c
0.20.x: 22b1d8c
0.19.x: 1bd705b

@codecov-io
Copy link

codecov-io commented Nov 8, 2017

Codecov Report

Merging #11836 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #11836      +/-   ##
==========================================
- Coverage   52.65%   52.61%   -0.04%     
==========================================
  Files         271      271              
  Lines       25730    25730              
  Branches     4105     4105              
==========================================
- Hits        13548    13539       -9     
- Misses      12182    12191       +9
Flag Coverage Δ
#unittest 52.61% <0%> (-0.04%) ⬇️
Impacted Files Coverage Δ
app/browser/windows.js 24.23% <0%> (ø) ⬆️
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 26.71% <0%> (-0.3%) ⬇️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++! 😄 I remember this being renamed; def a bad backport / merge

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants