Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

unable to drop lock/unlock icon onto folder on toolbar to create bookmark #12476

Closed
LaurenWags opened this issue Jan 3, 2018 · 2 comments
Closed

unable to drop lock/unlock icon onto folder on toolbar to create bookmark #12476

LaurenWags opened this issue Jan 3, 2018 · 2 comments
Assignees
@NejcZdovc
Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2018 •
edited by srirambv
Loading

Test Plan

  1. Open a site.
  2. Add a bookmark folder to the bookmarks toolbar.
  3. Drag and drop the unlock / lock icon from URL bar onto the folder, bookmark should be added into the bookmark folder

Description

When user drag and drop the un/lock icon from URL bar onto a folder in the toolbar, a bookmark should be created in that folder but it is not.

Steps to Reproduce

  1. Open a site.
  2. Add a bookmark folder to the bookmarks toolbar.
  3. Drag and drop the unlock / lock icon from URL bar onto the folder.

Actual result:
Bookmark is not added into the folder:
dnd-lock-02014

Expected result:
Bookmark should be added to the folder it was dropped onto as it is in 0.19.123:
dnd-lock-019123

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.14
V8 | 6.3.292.48
rev | 5d75826
Muon | 4.5.33

Reproducible on current live release:
no

Additional Information

Reported and fixed in 0.19.x with this issue: #11180
@LaurenWags LaurenWags added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@srirambv
Copy link
Collaborator

srirambv commented Jan 3, 2018

Confirmed on Windows too

@NejcZdovc NejcZdovc self-assigned this Jan 3, 2018
@NejcZdovc NejcZdovc mentioned this issue Jan 3, 2018
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 5, 2018
@NejcZdovc
Fixes dnd for url bar icon
7793647 
Resolves brave#12476

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 5, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 5, 2018
@NejcZdovc
Fixes dnd for url bar icon
8ed80f3 
Resolves brave#12476

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 5, 2018
@NejcZdovc
Fixes dnd for url bar icon
69b7bc3 
Resolves brave#12476

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 5, 2018
@NejcZdovc
Fixes dnd for url bar icon
ca6afa3 
Resolves brave#12476

Auditors:

Test Plan:
cezaraugusto added a commit that referenced this issue Jan 5, 2018
@cezaraugusto
Merge pull request #12515 from NejcZdovc/hotfix/#12476-drop
ec24079 
Fixes dnd for url bar icon
cezaraugusto added a commit that referenced this issue Jan 5, 2018
@cezaraugusto
Merge pull request #12515 from NejcZdovc/hotfix/#12476-drop
be72eb4 
Fixes dnd for url bar icon
cezaraugusto added a commit that referenced this issue Jan 5, 2018
@cezaraugusto
Merge pull request #12515 from NejcZdovc/hotfix/#12476-drop
70b6585 
Fixes dnd for url bar icon
@srirambv
Copy link
Collaborator

Works on Windows now
12476

@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.20.x issue first seen in 0.20.x bug feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @LaurenWags