Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes dnd for url bar icon #12515

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 5, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Resolves #12476

Auditors:

Test Plan:

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.20.x (Beta Channel) milestone Jan 5, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 5, 2018
@codecov-io
Copy link

codecov-io commented Jan 5, 2018

Codecov Report

Merging #12515 into master will increase coverage by 0.02%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master   #12515      +/-   ##
==========================================
+ Coverage   55.91%   55.93%   +0.02%     
==========================================
  Files         278      278              
  Lines       26983    26969      -14     
  Branches     4363     4361       -2     
==========================================
- Hits        15087    15086       -1     
+ Misses      11896    11883      -13
Flag Coverage Δ
#unittest 55.93% <40%> (+0.02%) ⬆️
Impacted Files Coverage Δ
js/actions/windowActions.js 5% <ø> (+0.04%) ⬆️
js/constants/windowConstants.js 100% <ø> (ø) ⬆️
app/renderer/reducers/frameReducer.js 57.5% <ø> (+2.78%) ⬆️
app/renderer/components/navigation/urlBarIcon.js 72.3% <0%> (-0.42%) ⬇️
js/dnd.js 28.72% <66.66%> (+1.54%) ⬆️

Resolves brave#12476

Auditors:

Test Plan:
@cezaraugusto
Copy link
Contributor

heads-up at one point I got this error:

[7157:775:0105/180803.419843:ERROR:CONSOLE(0)] "(WEBUI context) http://localhost:8080/gen/app.entry.js:96566: Uncaught Error: function () {
        dnd.onDragEnd();
      } could not be cloned.{Error: function () {
        dnd.onDragEnd();
      } could not be cloned.
    at EventEmitter.ipc.on (http://localhost:8080/gen/app.entry.js:96566:34)
    at emitTwo (extensions::event_emitter:105:13)
    at EventEmitter.emit (extensions::event_emitter:193:7)
    at EventEmitter.ipcRenderer.emit (extensions::ipc_utils:35:22)}", source: chrome://brave/Users/cezaraugusto/dev/browser-laptop/app/extensions/brave/index-dev.html (0)

I wasn't able to replicate that again and since the above didn't break anything I think we're ok for now.

@cezaraugusto cezaraugusto merged commit ec24079 into brave:master Jan 5, 2018
cezaraugusto added a commit that referenced this pull request Jan 5, 2018
cezaraugusto added a commit that referenced this pull request Jan 5, 2018
@cezaraugusto
Copy link
Contributor

master ec24079
0.21.x be72eb4
0.20.x 70b6585

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants