Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

add "Enable Brave Payments" to the bravery menu #3592

Closed
bradleyrichter opened this issue Aug 31, 2016 · 2 comments
Closed

add "Enable Brave Payments" to the bravery menu #3592

bradleyrichter opened this issue Aug 31, 2016 · 2 comments
Assignees
@ayumi
Labels
feature/rewards feature/shields
Milestone
0.12.1dev

Comments

@bradleyrichter
Copy link
Contributor

This will help some users find Brave Payments as one of several paths.
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Aug 31, 2016
@bradleyrichter bradleyrichter modified the milestones: 0.12.1dev, 1.0.0, 0.12.2dev Sep 7, 2016
@ayumi
Copy link
Contributor

ayumi commented Sep 12, 2016

Is the bravery menu the OS menu like
screen shot 2016-09-12 at 10 45 44

and if Payments is already enabled, should it become "Disable Brave Payments"?

@bradleyrichter
Copy link
Contributor Author

bradleyrichter commented Sep 12, 2016 •
edited
Loading

@ayumi Yes.

This is mostly for user awareness so we could use a different approach like:

If BP is OFF, then menu = "Start using Brave Payments..."

If BP is ON, then menu = "Brave Payments..." (or "Open Brave Payments...")

This avoids using an actual toggle menu since we don't really want you to turn it off outside of the payments panel.

@ayumi ayumi self-assigned this Sep 12, 2016
ayumi added a commit that referenced this issue Sep 12, 2016
@ayumi
Add Payments to system menu Bravery
3c760e3 
Close #3592

Auditors: @bradleyrichter @diracdeltas

Test Plan:

1. Disable Payments
2. Open OS menu "Bravery"
3. See menu item "Start using Brave payments..." -- click it
4. Tab opens to Prefs > Payments
5. Enable Payments
6. Close tab
7. Open OS menu "Bravery" again
8. Payments menu item now says "Brave payments"
9. Close and reopen Brave
10. Menu item still says "Brave payments"
@ayumi ayumi mentioned this issue Sep 12, 2016
Merged
4 tasks
@bbondy bbondy modified the milestones: 0.12.1dev, 0.12.2dev Sep 12, 2016
@alexwykoff alexwykoff mentioned this issue Sep 15, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayumi ayumi

Labels
feature/rewards feature/shields
Projects
None yet
Milestone
0.12.1dev
Development

No branches or pull requests
4 participants
@ayumi @bbondy @luixxiul @bradleyrichter