Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Payments to Bravery system menu #3929

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Conversation

ayumi
Copy link
Contributor

@ayumi ayumi commented Sep 12, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Close #3592

Auditors: @bradleyrichter @diracdeltas

Test Plan:

  1. Disable Payments
  2. Open OS menu "Bravery"
  3. See menu item "Start using Brave payments..." -- click it
  4. Tab opens to Prefs > Payments
  5. Enable Payments
  6. Close tab
  7. Open OS menu "Bravery" again
  8. Payments menu item now says "Brave payments"
  9. Close and reopen Brave
  10. Menu item still says "Brave payments"

Close #3592

Auditors: @bradleyrichter @diracdeltas

Test Plan:

1. Disable Payments
2. Open OS menu "Bravery"
3. See menu item "Start using Brave payments..." -- click it
4. Tab opens to Prefs > Payments
5. Enable Payments
6. Close tab
7. Open OS menu "Bravery" again
8. Payments menu item now says "Brave payments"
9. Close and reopen Brave
10. Menu item still says "Brave payments"
@luixxiul
Copy link
Contributor

#3675 should be applied here too I think

@ayumi
Copy link
Contributor Author

ayumi commented Sep 12, 2016

@luixxiul i like that – i'd like to update it in a new PR

@bsclifton
Copy link
Member

@ayumi does this also cover the hamburger menu? I know there is shared code (so it might 😄)
screen shot 2016-09-12 at 1 09 49 pm

@ayumi
Copy link
Contributor Author

ayumi commented Sep 12, 2016

@bsclifton yess

screen shot 2016-09-12 at 13 39 18

@diracdeltas
Copy link
Member

++ thanks

@diracdeltas diracdeltas merged commit 0934f9b into master Sep 12, 2016
@diracdeltas diracdeltas deleted the feature/payments-menu-item branch September 12, 2016 20:51
@luixxiul luixxiul added this to the 0.12.1dev milestone Sep 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants