Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Localization of Payments FAQ text on about:payments #4102

Closed
luixxiul opened this issue Sep 19, 2016 · 3 comments
Closed

Localization of Payments FAQ text on about:payments #4102

luixxiul opened this issue Sep 19, 2016 · 3 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 19, 2016

Describe the issue you encountered:
These lines on about:payments should be localizable in languages whose grammar is different from English.

<span data-l10n-id='paymentsWelcomeText6' />&nbsp;
    <a href='https://brave.com/Payments_FAQ.html' target='_blank' data-l10n-id='paymentsWelcomeLink' />&nbsp;
<span data-l10n-id='paymentsWelcomeText7' />

<span data-l10n-id='paymentsWelcomeText6' />&nbsp;
<a href='https://brave.com/Payments_FAQ.html' target='_blank' data-l10n-id='paymentsWelcomeLink' />&nbsp;
<span data-l10n-id='paymentsWelcomeText7' />

In Japanese, based on the current status, they need to be sorted reversely. Also no whitespaces should exist there because it is gramatically wrong to have ones in a sentence.

Expected behavior:
Make paymentsWelcomeText6 and paymentsWelcomeText7 concatenated and include the URL in it as a variable like this: https://github.com/luixxiul/browser-laptop/commit/ef284caa8be29a62ea18f68cc38f8f7c4d0244fa. Also whitespaces should not be hardcorded, and let translators handle them.

  • Brave Version: 0.12.1
  • Screenshot if needed:

Currently you get this:

clipboard01

It could be improved like this, which is grammartically correct:

clipboard01

  • Any related issues:
@luixxiul luixxiul added this to the 0.12.3dev milestone Sep 21, 2016
@mrose17 mrose17 modified the milestones: 0.12.4dev, 0.12.3dev, 0.12.5dev Sep 27, 2016
@mrose17 mrose17 removed this from the 0.12.5dev milestone Oct 4, 2016
@luixxiul luixxiul added the bug label Oct 14, 2016
@mrose17 mrose17 added this to the 1.1.0 milestone Oct 17, 2016
@luixxiul luixxiul modified the milestones: contributor backlog, 1.1.0 Dec 23, 2016
@bsclifton
Copy link
Member

@luixxiul if you think about the spans that are in place as tokens (instead of a block of text that must be translated as-is), you can already solve this without code changes:

<span data-l10n-id='paymentsWelcomeText6' />&nbsp;
  <a href='https://brave.com/Payments_FAQ.html' target='_blank' data-l10n-id='paymentsWelcomeLink' />&nbsp;
<span data-l10n-id='paymentsWelcomeText7' />

(I can't copy/paste your text above, since it's in an image, but I'll try to simulate)

paymentsWelcomeText6=Words before link
paymentsWelcomeLink=link text goes here
paymentsWelcomeText7=words after link

The variable strategy like you suggest is great- but in this case, it would be generating an HTML element (which I believe is out of scope for a translation). In this case, the folks doing the translation would need to be aware of how the strings are used in the UI, which I think is acceptable (instead of them blindly translating the strings)

Thoughts? cc: @aekeus @alexwykoff @bbondy

@bsclifton
Copy link
Member

Removing ledger tag since this is really a content / i18n issue and not something that impacts Brave Payments functionality

@luixxiul luixxiul added the bug label Apr 10, 2017
@luixxiul luixxiul removed this from the contributor backlog milestone Apr 10, 2017
@cndouglas cndouglas self-assigned this Apr 11, 2017
@cndouglas
Copy link

See #8162 (comment)

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants