-
Notifications
You must be signed in to change notification settings - Fork 975
Release note link texts should be l10n-friendly #8162
Comments
If you are not familiar with the editor on transifex, here is a part of the list which contains untranslated strings: Just translating each word does not make sense in a sentence due to grammatical difference. They actually should be in one sentence: |
The way the strings are placed has the issue on not only Japanese but also German: #8177. FYI in Japanese, in order to localize with the current sets, they need to be placed like this:
The way the strings are aligned are completely reversed. |
Edit: Removed other example of the problem already covered by #5733. Here's my idea for a solution:
The translator can choose where to place the link (1) and what the link text should be (2). In code, we create a localized link with (2) and replace For example, in Japanese, the translated strings would look like this:
|
@liunkae if that works that would be a nice solution :-) |
@luixxiul it should work great 😄 Here's a demo of where @liunkae did it with regards to Pocket: Although, this goes a step further by using a translated string as an argument... which should still work great 😄 |
@luixxiul Sure, I'll try. |
Two problems: I can't seem to replace |
I can't find a way to fix this without the ability to dynamically get translated strings. I'll try fixing this problem once #3946 is resolved. |
Describe the issue you encountered: https://github.com/srirambv/browser-laptop/blob/07a49902262239d8c1f0872e2129a39811e45599/js/about/brave.js#L52-L56
Release note link texts should be l10n-friendly.
s (not every language has whitespaces)I wish @liunkae has some ideas to fix the issue (replace the variable for Transifex with a function, etc)
Brave Version (revision SHA): 0.14.2 Preview 1
Any related issues: Localization of Payments FAQ text on about:payments #4102 Localization of Pepper Flash instruction on about:preferences#security #5733 Added release notes link to about:brave #7791
The text was updated successfully, but these errors were encountered: