Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show bookmarks toolbar after data import #4507

Closed
srirambv opened this issue Oct 4, 2016 · 1 comment · Fixed by #4587
Closed

Show bookmarks toolbar after data import #4507

srirambv opened this issue Oct 4, 2016 · 1 comment · Fixed by #4587

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 4, 2016

Currently bookmark toolbar is shown only when a bookmark is added but not when data is imported. Many users might not realize that bookmarks toolbar is not enabled. Showing the toolbar after importing data will help users.

Setting milestone as 0.12.5 for now

@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

I think it's ok not to block on this, but I agree we should do it eventually.

@darkdh darkdh self-assigned this Oct 6, 2016
@darkdh darkdh added this to the 0.12.4dev milestone Oct 6, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 6, 2016
…ng bookmarks successfully

fix brave#4507

Auditors: @bbondy

Test Plan:
1. Make sure bookmakrs toolbar doesn't show
2. Import bookmarks
3. bookmarks toolbar will show after successful import
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 6, 2016
…ng bookmarks successfully

fix brave#4507

Auditors: @bbondy

Test Plan:
1. Make sure bookmakrs toolbar doesn't show
2. Import bookmarks from browser
3. bookmarks toolbar will show after successful import

1. Make sure bookmakrs toolbar doesn't show
2. Import bookmarks from html
3. bookmarks toolbar will show after successful import

1. Make sure bookmakrs toolbar doesn't show
2. Make sure there already exist some bookmarks
3. Import bookmarks from browser
4. bookmarks toolbar should not show after successful import

1. Make sure bookmakrs toolbar doesn't show
2. Make sure there already exist some bookmarks
3. Import bookmarks from html
4. bookmarks toolbar should not show after successful import
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.