Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

When importing on a clean install, it appears as though nothing has happened #4586

Closed
alexwykoff opened this issue Oct 6, 2016 · 3 comments · Fixed by #4590
Closed

When importing on a clean install, it appears as though nothing has happened #4586

alexwykoff opened this issue Oct 6, 2016 · 3 comments · Fixed by #4590
Assignees
@darkdh
Labels
QA/checked-macOS QA/checked-Win64
Milestone
0.12.4dev

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When importing data to a clean install of Brave, the bookmarks toolbar does not open (#4507) and the bookmarks menu is not updated (#3968, #4390, #4227).

Expected behavior:
When importing data, the newly imported data should be immediately available to the user upon successful completion.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    0.12.4 Preview 3
  • Steps to reproduce:
    1. With a clean install, (move away any prior /brave folders) import from another browser with bookmarks and folders.
    2. Check that the bookmarks toolbar opens and that the bookmarks menu is updated.
  • Screenshot if needed:
    import_base_case
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.12.4dev milestone Oct 6, 2016
@alexwykoff
Copy link
Contributor Author

cc @bsclifton

@bbondy
Copy link
Member

bbondy commented Oct 6, 2016

/cc @darkdh

@darkdh darkdh self-assigned this Oct 6, 2016
@darkdh
Copy link
Member

darkdh commented Oct 6, 2016

no bookmarks toolbar problem fixed in #4507

@bbondy bbondy closed this as completed Oct 6, 2016
@bbondy bbondy reopened this Oct 6, 2016
@bbondy bbondy modified the milestones: 0.12.5dev, 0.12.4dev Oct 6, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 6, 2016
@darkdh
Add addSite with list to rebuild
08c5c1f 
fix brave#4586

Auditors: @bsclifton

Test Plan:
1. Import bookmarks from other browsers or html file
2. The imported bookmarks should show in "Bookmarks" menu
@darkdh darkdh mentioned this issue Oct 6, 2016
Merged
4 tasks
@luixxiul luixxiul modified the milestones: 0.12.4dev, 0.12.5dev Oct 6, 2016
This was referenced Oct 7, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.4dev
Development

Successfully merging a pull request may close this issue.

Add addSite with list to rebuild darkdh/browser-laptop
6 participants
@aekeus @bbondy @alexwykoff @luixxiul @darkdh @srirambv