Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added new strings to handle overdue payments #7078

Closed
da2x opened this issue Feb 4, 2017 · 1 comment
Closed

Added new strings to handle overdue payments #7078

da2x opened this issue Feb 4, 2017 · 1 comment

Comments

@da2x
Copy link
Contributor

da2x commented Feb 4, 2017

Test Plan:

  • Create a new wallet
  • Stop browser
  • Set reconcileStamp ledger-state.json to the current timestamp or more than a day in the past.
  • Verify that the text indicates "is due" an "is coverdue" instead of suggesting a future event.

Original issue description

  • “Your first contribution will be 24 days ago.”
  • “Your next contribution will be 18 days ago.”

So these need to be modified to handle the correct tense when payment is overdue. I’m uncertain about any localization implications this may have or how this should be best handled. Pull request #7077 handles a related string, but not this issue.

@bradleyrichter bradleyrichter added this to the 0.13.3 milestone Feb 13, 2017
@bradleyrichter bradleyrichter modified the milestones: 1.0.0, 0.13.3 Feb 13, 2017
@mrose17 mrose17 removed this from the 1.0.0 milestone Feb 21, 2017
@mrose17 mrose17 added this to the 0.13.6 milestone Mar 7, 2017
mrose17 added a commit that referenced this issue Mar 7, 2017
@bsclifton
Copy link
Member

bsclifton commented Mar 13, 2017

Note to testers:

UI will change with #7532 which invalidates part of this PR. See notes from discussion in the PR that fixes this issue: #7524 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.