This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Payment UI 1.0 #7532
Merged
Payment UI 1.0 #7532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
feature/#7348-payment-ui
branch
from
2fda52b
to
828470c
Compare
4 tasks
NejcZdovc
force-pushed
the
feature/#7348-payment-ui
branch
from
828470c
to
c988c37
Compare
Resolves brave#7348 Auditors: @bsclifton @bradleyrichter Test Plan: - layout should be the same as is on mock in issue brave#7348
NejcZdovc
force-pushed
the
feature/#7348-payment-ui
branch
from
c988c37
to
bf58800
Compare
NejcZdovc
requested review from
bsclifton,
bradleyrichter and
cezaraugusto
and removed request for
cezaraugusto,
bsclifton and
bradleyrichter
|
@bsclifton @cezaraugusto @bradleyrichter Now that #7481 is in, this PR can be reviewed |
bsclifton
approved these changes
Mar 13, 2017
There was a problem hiding this comment.
Changes look great!
Only one thing I noticed (screenshot attached): when you don't have a contribution history, the SVG icon is hidden. Should we instead show it as grayed out? (so that users know it is there?)
it could be present but grayed out next to the gear icon
|
Looks good! Comments left (if action should be taken, let's do as a follow up). Thanks 😄 |
bsclifton
added
QA/test-plan-specified
release-notes/include
and removed
PR/needs-QA-attention ☕
labels
|
@NejcZdovc yes, it would be great to have the icon in grey for the "no history yet" state. |
|
Follow up task created for ya, @NejcZdovc 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Description
git rebase -ito squash commits (if needed).Resolves #7348
NOTE
Auditors
@bsclifton @bradleyrichter