Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

When fullscreen (on macOS), move the nav controls left #7872

Closed
bsclifton opened this issue Mar 24, 2017 · 4 comments
Closed

When fullscreen (on macOS), move the nav controls left #7872

bsclifton opened this issue Mar 24, 2017 · 4 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 24, 2017

Test plan

#8514 (comment)

  1. Launch Brave on macOS
  2. Click the green button in the top left to trigger full screen mode
  3. Notice the back/forward arrows move after the traffic lights disappear
  4. Move mouse into top left corner, hit green button to un-trigger full screen mode
  5. Notice traffic lights appear again and back/forward arrows pop to the right again

Original issue description

Screenshot of user fullscreen:
image

Notice in the top left there is a blank area where the traffic lights used to be (red / yellow / green buttons). This area should disappear

@bsclifton bsclifton added bug/good-first-bug design A design change, especially one which needs input from the design team. OS/macOS labels Mar 24, 2017
@freebrowser1
Copy link

freebrowser1 commented Mar 26, 2017

But the top-left stoplight buttons do appear in the titlebar.

screen shot 2017-03-26 at 10 55 46

Additionally, this title bar and tabs bar should disappear as well to become really 'full screen' (and obviously reappear when mouse is moved to top).

@luixxiul
Copy link
Contributor

But the top-left stoplight buttons do appear in the titlebar.

Because the window is not in the fullscreen mode, which is different from the maxmized window.

kumarrishav added a commit to kumarrishav/browser-laptop that referenced this issue Apr 26, 2017
@kumarrishav
Copy link
Contributor

I would like to a shot to this one :)

@bsclifton
Copy link
Member Author

bsclifton commented Apr 26, 2017

@kumarrishav go for it 😄 Let me know if you have any questions

(I assigned myself so that we know somebody is working on it- I can help you review / test)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.