This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
move the nav controls to left in full screen mode - in macOS Fix #7872 #8514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cndouglas
suggested changes
Apr 27, 2017
cndouglas
added
design
|
Please look for something like |
|
@luixxiul How should i check, if screen is in full screen mode or not? |
|
@kumarrishav so instead of modifying less file, you need to modify some js file. More specifically |
kumarrishav
force-pushed
the
moveNavLeft
branch
from
a02c19d
to
008758f
Compare
|
@liunkae review? |
NejcZdovc
reviewed
Apr 28, 2017
| @@ -225,7 +225,7 @@ class Navigator extends ImmutableComponent { | |||
| onDragOver={this.onDragOver} | |||
| onDrop={this.onDrop} | |||
| > | |||
| <div className='backforward'> | |||
| <div className={'backforward' + (isFullScreen() ? ' fullscreen' : '')}> | |||
There was a problem hiding this comment.
Please use cx syntax for class name, you can see example bellow. Thank you
There was a problem hiding this comment.
fixed. I wasn't aware of this utility func. @NejcZdovc Thanks .
kumarrishav
force-pushed
the
moveNavLeft
branch
from
008758f
to
7a06897
Compare
cndouglas
approved these changes
Apr 28, 2017
bsclifton
approved these changes
May 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Description
git rebase -ito squash commits (if needed).Resolves #7872
Test Plan:
