-
Notifications
You must be signed in to change notification settings - Fork 975
Added release notes link to about:brave #7791
Conversation
@srirambv can you resolve the conflicts? This just needs a rebase. I can review in the meantime and then accept quickly if everything looks good 😄 thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the spec (the issue, screenshot)- there should be a link to a specific version (or tag) of Brave. If we always link to the latest version, people several versions from now may mistakenly think they're on the latest
Trying to find this might not be easy- we definitely have the hash available... but we'll need to do a lookup (AJAX call, etc) to find a tag with that associated SHA.
@bsclifton conflicts resolved |
Changed href to use the installed ver to open the release notes page. Thanks to @NejcZdovc for the help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me!
I wanted to add Brad as a reviewer here, since there is an update to the copy (ex: it now says About Brave - Browse faster and safer with Brave.
) and the look. We could use this opportunity to put a Lion logo in there (I can help with this if needed)
"Release Notes" should get the same style as "Version Information" because "About Brave" should be the primary title. I don't think we need a lion icon here, and it would upset the alignment unless we make it a 2 column layout. |
@srirambv Link implementation looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would agree with @bradleyrichter. Except that, LGTM.
Changed href to point to installed ver
Thanks for the quick update @bsclifton 👍 |
Test Plan
Browse faster and safer with Brave.
belowAbout Brave
Release Notes
Description
git rebase -i
to squash commits (if needed).app.properties file alphabetized for easier readability and future new additions, new values for the PR in line 35, 177-180Closes: #6130