Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

copying URLbar text opens the autosuggest dialog #8896

Closed
diracdeltas opened this issue May 16, 2017 · 1 comment
Closed

copying URLbar text opens the autosuggest dialog #8896

diracdeltas opened this issue May 16, 2017 · 1 comment
Assignees
@diracdeltas
Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.15.300 (Frozen,...

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 16, 2017 •
edited
Loading

cmd+c in the url bar on mac opens the autosuggest dialog.

STR:

  1. click on urlbar and highlight the text
  2. hit cmd+c to copy
  3. observe the autosuggest dialog pops up

The same issue exists with cmd+x, which was fixed previously: 394d1e3
@diracdeltas diracdeltas added this to the 0.15.300 milestone May 16, 2017
@diracdeltas diracdeltas self-assigned this May 16, 2017
diracdeltas added a commit that referenced this issue May 17, 2017
@diracdeltas
Fix urlbar suggestions showing up when non-printable keys are pressed
d165e31 
Fix #8896

Test Plan:
1. `npm run test -- --grep='press keyboard shortcut'` should pass
2. go to a site with autocomplete entries; ex: twitter.com. press cmd+L to focus the urlbar and the cmd+C to copy. the autosuggest dialog should not appear.
diracdeltas added a commit that referenced this issue May 17, 2017
@diracdeltas
Fix urlbar suggestions showing up when non-printable keys are pressed
90360ae 
Fix #8896

Test Plan:
1. `npm run test -- --grep='press keyboard shortcut'` should pass
2. go to a site with autocomplete entries; ex: twitter.com. press cmd+L to focus the urlbar and the cmd+C to copy. the autosuggest dialog should not appear.
@diracdeltas diracdeltas mentioned this issue May 17, 2017
Merged
7 tasks
@bsclifton
Copy link
Member

Marked as release-notes/exclude since it was introduced with this version too

bsclifton pushed a commit that referenced this issue May 17, 2017
@diracdeltas @bsclifton
Fix urlbar suggestions showing up when non-printable keys are pressed
6ce4945 
Fix #8896

Test Plan:
1. `npm run test -- --grep='press keyboard shortcut'` should pass
2. go to a site with autocomplete entries; ex: twitter.com. press cmd+L to focus the urlbar and the cmd+C to copy. the autosuggest dialog should not appear.
This was referenced May 23, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue May 25, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
5 participants
@diracdeltas @alexwykoff @luixxiul @bsclifton @srirambv