Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix urlbar suggestions showing up when non-printable keys are pressed #8903

Merged
merged 1 commit into from
May 17, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 17, 2017

Fix #8896

Test Plan:

  1. npm run test -- --grep='press keyboard shortcut' should pass
  2. go to a site with autocomplete entries; ex: twitter.com. press cmd+L to focus the urlbar and the cmd+C to copy. the autosuggest dialog should not appear.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fix #8896

Test Plan:
1. `npm run test -- --grep='press keyboard shortcut'` should pass
2. go to a site with autocomplete entries; ex: twitter.com. press cmd+L to focus the urlbar and the cmd+C to copy. the autosuggest dialog should not appear.
@diracdeltas diracdeltas added this to the 0.15.300 milestone May 17, 2017
@diracdeltas diracdeltas self-assigned this May 17, 2017
@diracdeltas diracdeltas requested a review from bbondy May 17, 2017 05:42
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test plan works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants