Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Notification bar - buttons not responding #9171

Closed
Swader opened this issue May 31, 2017 · 5 comments · Fixed by #10178
Closed

Notification bar - buttons not responding #9171

Swader opened this issue May 31, 2017 · 5 comments · Fixed by #10178

Comments

@Swader
Copy link

Swader commented May 31, 2017

Test plan

  1. Turn on autoplay to always ask and make sure there is no any allow
    autoplay permissions (Preferences > Security tab)
  2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification
    bar
  3. Open another tab and go to
    https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay
    and still don't click on notification bar
  4. Go back the youtube tab you will find out the notification bar is now
    clickable (before fix, it was non clickable)
  5. Go to the w3schools tab and it will also be clickable (before fix, it was non clickable)

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    On some pages / popups, clicks don't work:

  • The autoplay permission bar on messenger.com didn't register my clicks, but started working after a browser restart. On other sites it worked.

brave

  • I've noticed clicks stop working from time to time on various pages and windows, in particular in popups: when developer tools are opened, right click doesn't work. On popups opened by OAuth pages, for example, the lastpass popup for selecting accounts with which to populate fields won't be able to spawn.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

OS X

  • Brave Version (revision SHA):

6b5e4e2

  • Steps to reproduce:

    1. Use Brave
    2. Trigger autoplay question on as many sites as possible
    3. Click any of the buttons
  • Actual result:
    Eventually, the click will no longer register

  • Expected result:
    Clicks shouldn't be a luxury or a lottery and should register every time.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Not sure, doubt it. I think it has to stay open for a while to accumulate the typical NodeJS memleak lake.

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    No

  • Any related issues:
    Possibly, I've been told there have been reports of non working context menus and clicks, but cannot find them.

@bsclifton
Copy link
Member

@darkdh @bradleyrichter didn't one of you have this issue recently?

@darkdh
Copy link
Member

darkdh commented Jul 11, 2017

dup #9780
Actually, we should keep this and close #9780

@darkdh darkdh self-assigned this Jul 11, 2017
@darkdh darkdh added this to the 0.19.x (Developer Channel) milestone Jul 11, 2017
@alexwykoff alexwykoff removed this from the 0.19.x (Beta Channel) milestone Jul 18, 2017
@darkdh
Copy link
Member

darkdh commented Jul 26, 2017

Specific STR:

  1. Turn on autoplay to always ask and make sure there is no any allow autoplay permissions
  2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification bar
  3. Open another tab and go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay and still don't click on notification bar
  4. Go back the youtube tab you will find out the notification bar is non clickable
  5. Go to the w3schools tab and it will also be non clickable

darkdh added a commit that referenced this issue Jul 27, 2017
fixes #9143
fixes #9008
fixes #9171

Auditors: @bsclifton, @bridiver, @cezaraugusto

Test Plan:
Covered by automatic test

Specific STR for #9171:
1. Turn on autoplay to `always ask` and make sure there is no any allow
autoplay permissions
2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification
bar
3. Open another tab and go to
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay
and still don't click on notification bar
4. Go back the youtube tab you will find out the notification bar is non
clickable
5. Go to the w3schools tab and it will also be non clickable
@darkdh darkdh mentioned this issue Jul 27, 2017
8 tasks
@darkdh darkdh added this to the 0.20.x (Nightly Channel) milestone Jul 27, 2017
@bsclifton bsclifton changed the title Clicking issues on various pages / windows Notification bar - buttons not responding Jul 30, 2017
darkdh added a commit that referenced this issue Jul 31, 2017
fixes #9143
fixes #9008
fixes #9171

Auditors: @bsclifton, @bridiver, @cezaraugusto

Test Plan:
Covered by automatic test

Specific STR for #9171:
1. Turn on autoplay to `always ask` and make sure there is no any allow
autoplay permissions
2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification
bar
3. Open another tab and go to
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay
and still don't click on notification bar
4. Go back the youtube tab you will find out the notification bar is non
clickable
5. Go to the w3schools tab and it will also be non clickable
@darkdh darkdh modified the milestones: 0.20.x (Beta Channel), 0.19.x Hotfix 11 (Release Channel) Jan 4, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2018

Clearing flags as this was tested against 0.20.x, needs to be re-tested against 0.19.x.

@srirambv
Copy link
Collaborator

srirambv commented Jan 5, 2018

Verified on 0.19.126 build. Test plan works

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.