This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Autoplay refactoring #10178
Merged
Autoplay refactoring #10178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
bsclifton
suggested changes
Jul 30, 2017
There was a problem hiding this comment.
Changes look great! ❤️ Really nice work on this one 😄 👍
When I run the unit tests, I am seeing one error (not sure if related):
1) menuUtil tests createRecentlyClosedTemplateItems returns an array of closedFrames preceded by a separator and "Recently Closed" items:
AssertionError: '' == 'RECENTLYCLOSED'
+ expected - actual
+RECENTLYCLOSED
Can you check this out?
|
looking at it. |
fixes #9143 fixes #9008 fixes #9171 Auditors: @bsclifton, @bridiver, @cezaraugusto Test Plan: Covered by automatic test Specific STR for #9171: 1. Turn on autoplay to `always ask` and make sure there is no any allow autoplay permissions 2. Go to https://youtu.be/g_6yBZKj-eo and don't click on notification bar 3. Open another tab and go to https://www.w3schools.com/tags/tryit.asp?filename=tryhtml5_video_autoplay and still don't click on notification bar 4. Go back the youtube tab you will find out the notification bar is non clickable 5. Go to the w3schools tab and it will also be non clickable
darkdh
force-pushed
the
autoplay_refactor
branch
from
a0b5d9d
to
1a49ab8
Compare
|
missing |
Codecov Report
@@ Coverage Diff @@
## master #10178 +/- ##
==========================================
+ Coverage 52.78% 52.93% +0.15%
==========================================
Files 227 228 +1
Lines 20219 20295 +76
Branches 3237 3251 +14
==========================================
+ Hits 10672 10744 +72
- Misses 9547 9551 +4
|
|
0.19.x 5a7a5da |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9143 - Autoplay notification should be dismissed if user ignores notification and continues stream
fixes #9008 - Playing media on a site adds it to the autoplay site permission list (even when defaulted to "always allow")
fixes #9171 - Notification bar - buttons not responding
Auditors: @bsclifton, @bridiver, @cezaraugusto
Test Plan:
(see top of each issue for steps to test)
Automated test plan
Covered by automated tests (see travis-ci output)
Tests added by this PR:
npm run test -- --grep="autoplay"npm run unittest -- --grep="autoplayReducer unit tests"Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests