Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Second key for Brave Payments is not displayed on the UI after recovering wallet #9740

Closed
LaurenWags opened this issue Jun 27, 2017 · 5 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jun 27, 2017

Test plan

See below


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Second key for Brave Wallet is not displayed on the UI after recovery. Does not matter if you import keys or copy/past them into fields manually.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    Brave 0.17.11
    rev bc6d5b8
    Muon 4.1.4

  • Steps to reproduce:

    1. Enable Payments in Preferences.
    2. Click on the gear icon to open Advanced Settings.
    3. Select Recover your wallet.
    4. Import recovery keys from a previously saved file.
    5. You will get a successful message. Click OK.
    6. Click on gear icon again.
    7. Click on backup your wallet.
    8. Key 2 is not displayed.
  • Actual result:
    Key 2 is not displayed.

  • Expected result:
    Both keys should be displayed

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:

    1. Repeat steps above except manually copy/paste keys from file instead of importing. Key 2 is still not displayed on the UI.
  • Screenshot if needed:

  • Any related issues:

@LaurenWags LaurenWags added this to the 0.19.x (Nightly Channel) milestone Jun 27, 2017
@alexwykoff alexwykoff modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Jul 18, 2017
@bsclifton
Copy link
Member

Per #10442 (comment), @luixxiul reports that clicking the copy buttons give an error to console:

An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Error processing argument at index 0, conversion failure from null
    at EventEmitter.ipcMain.on (/usr/lib/brave/resources/app.asar/app/index.js:255:26)
    at emitTwo (events.js:106:13)
    at EventEmitter.emit (events.js:194:7)
    at WebContents.<anonymous> (/usr/lib/brave/resources/electron.asar/browser/api/web-contents.js:182:13)
    at emitTwo (events.js:106:13)
    at WebContents.emit (events.js:194:7)

@ghost ghost modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Sep 26, 2017
@ghost
Copy link

ghost commented Sep 26, 2017

Revisit after #10953 is merged

@NejcZdovc NejcZdovc self-assigned this Sep 29, 2017
@NejcZdovc
Copy link
Contributor

This was broken in client library, so I upstreamed the fix

brave-intl/bat-client#6
brave/ledger-client#23

@LaurenWags
Copy link
Member Author

Still experiencing this issue on 0.19.28.

@LaurenWags LaurenWags reopened this Oct 4, 2017
@NejcZdovc
Copy link
Contributor

we upgraded libraries that have this fix in #11231

NejcZdovc added a commit that referenced this issue Oct 6, 2017
Resolves #9740
Resolves #10945
Resolves #11251 
Resolves #11264
Resolves #11285
Resolves #11289
Resolves #11292
Resolves #11293
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Resolves brave#9740
Resolves brave#10945
Resolves brave#11251 
Resolves brave#11264
Resolves brave#11285
Resolves brave#11289
Resolves brave#11292
Resolves brave#11293
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants