This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Adds support for BAT in brave payments #10953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10953 +/- ##
==========================================
+ Coverage 54.14% 54.33% +0.19%
==========================================
Files 248 248
Lines 21751 21680 -71
Branches 3383 3363 -20
==========================================
+ Hits 11777 11780 +3
+ Misses 9974 9900 -74
|
Resolves brave#10945 Auditors: Test Plan:
NejcZdovc
force-pushed
the
feature/#10945-ledger
branch
from
995a476
to
73f9795
Compare
|
waiting for new flow and design |
|
Removing label |
8 tasks
luixxiul
reviewed
Sep 20, 2017
| ? <ModalOverlay | ||
| title={'bitcoinBuy'} | ||
| content={this.bitcoinOverlayContent()} | ||
| customDialogClasses={css(styles.modalOverlay__coinbaseOverlay)} |
There was a problem hiding this comment.
Just in case please remove or edit https://github.com/NejcZdovc/browser-laptop/blob/73f9795019a37e5b94cd41eb42cc12857353ccc4/app/renderer/components/preferences/payment/bitcoinDashboard.js#L463-L501 if modalOverlay__coinbaseOverlay is no longer used.
ghost
mentioned this pull request
|
closing in favour of #11231 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #10945
Resolves #10953
Auditors:
Test Plan:
Reviewer Checklist:
Tests