Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Redundant Suggestions #9827

Closed
jonathansampson opened this issue Jul 1, 2017 · 1 comment
Closed

Redundant Suggestions #9827

jonathansampson opened this issue Jul 1, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
bug feature/autocomplete feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Jul 1, 2017 •
edited by luixxiul
Loading

Test plan

See below

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Identical history suggestions are offered.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Brave Version (revision SHA):
    f7242c7

  • Steps to reproduce:
    I visit TweetDeck often. I assume you need only do the same in order to reproduce.

TweetDeck URLs show up in a couple different frame histories in my session-store-1 file:

"history": [
	"https://tweetdeck.twitter.com/#",
	"https://tweetdeck.twitter.com/#",
	"https://tweetdeck.twitter.com/"
],
…
"history": [
	"https://tweetdeck.twitter.com/#",
	"https://tweetdeck.twitter.com/#"
],

  • Actual result:
    Identical history suggestions are offered.

  • Expected result:
    Suggestions should be a list of unique domains.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    N/A

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Screenshot if needed:

image
@jonathansampson jonathansampson added this to the 0.20.x (Nightly Channel) milestone Jul 1, 2017
@jonathansampson
Copy link
Collaborator Author

cc @bbondy

@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 9, 2017
@bbondy bbondy self-assigned this Aug 15, 2017
@NejcZdovc NejcZdovc mentioned this issue Sep 7, 2017
Closed
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned bbondy Sep 7, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 7, 2017
@NejcZdovc
Fixes duplicated root domains
f11c610 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 7, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 7, 2017
@NejcZdovc
Fixes duplicated root domains
d93dd7c 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 10, 2017
@NejcZdovc
Fixes duplicated root domains
b66f5a8 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
@ghost ghost added the sprint/1 label Sep 13, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 17, 2017
@NejcZdovc
Fixes duplicated root domains
2664db1 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 18, 2017
@NejcZdovc
Fixes duplicated root domains
83b3341 
Resolves brave#10826
Resolves brave#9827

Auditors:

Test Plan:
@LaurenWags LaurenWags mentioned this issue Sep 29, 2017
Open
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Jan 9, 2018
Closed
31 tasks
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/autocomplete feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
6 participants
@jonathansampson @bbondy @luixxiul @NejcZdovc @srirambv @LaurenWags