Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs are not updated after tabpage close #9922

Closed
NejcZdovc opened this issue Jul 9, 2017 · 6 comments
Closed

Tabs are not updated after tabpage close #9922

NejcZdovc opened this issue Jul 9, 2017 · 6 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jul 9, 2017

Test plan

See #10008

Original issue description

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    When you close the last tab in a page tab you get empty tabs toolbar.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    all

  • Brave Version (revision SHA):
    dc76f0a

  • Steps to reproduce:

    1. open two tab pages
    2. close the last tab in the tab page
  • Actual result:
    image

  • Expected result:
    Tab page is switched correctly.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    no

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@NejcZdovc NejcZdovc added this to the 0.19.x (Developer Channel) milestone Jul 9, 2017
@NejcZdovc NejcZdovc self-assigned this Jul 9, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 9, 2017
Resolves brave#9922

Auditors: @cezaraugusto

Test Plan:
-  open two tab pages
- close the last tab in the tab page
@luixxiul
Copy link
Contributor

luixxiul commented Jul 9, 2017

I think this is a duplicate of something. CC @srirambv for confirmation

@srirambv
Copy link
Collaborator

srirambv commented Jul 9, 2017

This is a duplicate of #3092 and a regression. The issue had got fixed with some change and has now resurfaced.

@luixxiul luixxiul added the bug label Jul 9, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.18.x (Beta Channel), 0.19.x (Developer Channel) Jul 11, 2017
@LaurenWags
Copy link
Member

+1 from me

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 12, 2017
Resolves brave#9922

Auditors: @cezaraugusto

Test Plan:
-  open two tab pages
- close the last tab in the tab page
@osyed
Copy link

osyed commented Jul 12, 2017

This is not a duplicate of #3092. That issue is about setting the focus after a tab is closed. This issue is about updating the tabs bar after the last tab is closed.

When the last (the right most) tab is closed the width of the remaining tabs is not updated right away. It updates when the mouse moves down and out of the tab bar or moves to the left and over the new last tab. This can be very annoying if trying to close several tabs on the right side of the tab bar. When you close the last tab, the remaining tabs are not updated so that the new last tab is under the mouse pointer. So you move the mouse pointer to the left attempting to close the last tab, but as soon as the pointer moves over the last tab the tabs are updated and the last tab shifts to the right and away from the pointer. Now you have to move the pointer to the right to close the last tab. The UI would feel much smoother if the tab bar was updated as soon as the last tab is closed.

@luixxiul
Copy link
Contributor

When the last (the right most) tab is closed the width of the remaining tabs is not updated right away.

I believe that is another issue.

@NejcZdovc
Copy link
Contributor Author

Based on our discussion with @cezaraugusto this PR is probably causing this regression #9809

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.