This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix about:brave; version information is always set (regardless of errors) #5692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Version information is always set (regardless of errors).
Code itself is now fault tolerant as well. Includes tests.
Fixes: #5633
Auditors: @jonathansampson, @bbondy
Manual test plan:
Automated test plan:
run
npm run test -- --grep="about:brave tests"