Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix about:brave; version information is always set (regardless of errors) #5692

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Fix about:brave; version information is always set (regardless of errors) #5692

merged 1 commit into from
Nov 16, 2016

Commits on Nov 16, 2016

  1. Version infromation is always set (regardless of errors). Code itself…

    … is now fault tolerant as well. Includes tests.
    
    Fixes: #5633
    
    Auditors: @jonathansampson, @bbondy
    
    Manual test plan:
    1. Move your session out of the way (or do a fresh install)
    2. Launch Brave
    3. Go to about:brave
    4. Notice version shows as expected
    
    Automated test plan:
    run `npm run test -- --grep="about:brave tests"`
    bsclifton committed Nov 16, 2016
    Configuration menu
    Copy the full SHA
    41dcb22 View commit details
    Browse the repository at this point in the history