This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add support for 32 bit linux builds #5977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auditors: @bridiver
Auditors: @bridiver
Auditors: @bridiver
Auditors: @bridiver
I think this is related to webtorrent and not chromium54, but fixing here since this is the next release Auditors: @bridiver
auditors: @bbondy
auditors: @bbondy @diractdeltas
Auditors: @bridiver
There was a prepublish command so I couldn't use the direct github repo. I decided to fork it and publish it. Changing the prepublish to postinstall was also undesirable because it would add more time to npm installs Auditors: @bridiver
|
Fixes #2468. |
|
IIRC, someone had made a PR to specifically have RPMs have x86_64 (which I think is the arch for 64 bit on Red Hat OSes)... let me check |
|
I think this is pretty much all good on chrome54? Good to target muon? |
bridiver
force-pushed
the
chromium54
branch
2 times, most recently
from
48833c9
to
7280390
Compare
|
So did the 32 bit build become available already? |
|
cc: @posix4e |
|
Soon!
…On Mon, Jan 9, 2017 at 8:40 AM Brian Clifton ***@***.***> wrote:
cc @posix4e <https://github.com/posix4e>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5977 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxN21JBZ8dAuZWu6rZurwmsFSABus8tks5rQmLvgaJpZM4LB_3Z>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is will change the name of our deb packages to have x64 instead of amd64. Do we care? RPMs will also be x64 instead of x86_64. Happy to keep it as is if we prefer