This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Refactor autofillAddressPanel.js and autofillCreditCardPanel.js #8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
luixxiul
added
PR/work-in-progress ⚒
PR/needs-QA-attention ☕
and removed
PR/blocked
PR/work-in-progress ⚒
PR/needs-QA-attention ☕
labels
|
sorry for delaying on this, could you rebase? |
|
np, after QA work. |
Closes #8099 Closes #8100 Addresses #7989 - Refactored with commonForm, replacing it with genericForm Aligned labels to the left and input textboxes to the right by applying display:flex - Added CommonFormLarge - Added cx to dialog.js for more readability - Removed .manageAutofillDataPanel from form.less Also: - Added testIds - Edited autofillTest.js and autofill.js TODO: refactor autofill.js with Aphrodite - Edited selectors.js Auditors: Test Plan: 1. Automated tests should pass 2. Open about:autofill 3. Add an address 4. Add a credit card 5. Visit https://www.roboform.com/filling-test-all-fields 6. Make sure the input forms can be filled
|
@cezaraugusto would you review again? if OK I'll merge this in, thanks. |
This was referenced Apr 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8099
Closes #8100
Addresses #7989 #8010
Aligned labels to the left and input textboxes to the right by applying display:flex
Also:
TODO: refactor autofill.js with Aphrodite
Auditors:
Test Plan:
git rebase -ito squash commits (if needed).