Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor autofillAddressPanel.js and autofillCreditCardPanel.js #8105

Merged
merged 1 commit into from
Apr 18, 2017
Merged

Refactor autofillAddressPanel.js and autofillCreditCardPanel.js #8105

merged 1 commit into from
Apr 18, 2017

Commits on Apr 18, 2017

  1. Refactor autofillAddressPanel.js and autofillCreditCardPanel.js

    Closes #8099
    Closes #8100
    Addresses #7989
    
    - Refactored with commonForm, replacing it with genericForm
      Aligned labels to the left and input textboxes to the right by applying display:flex
    
    - Added CommonFormLarge
    - Added cx to dialog.js for more readability
    - Removed .manageAutofillDataPanel from form.less
    
    Also:
    - Added testIds
    - Edited autofillTest.js and autofill.js
      TODO: refactor autofill.js with Aphrodite
    - Edited selectors.js
    
    Auditors:
    
    Test Plan:
    1. Automated tests should pass
    2. Open about:autofill
    3. Add an address
    4. Add a credit card
    5. Visit https://www.roboform.com/filling-test-all-fields
    6. Make sure the input forms can be filled
    Suguru Hirahara committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    77b7148 View commit details
    Browse the repository at this point in the history