Implement key sharing #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support private key extraction so multiple instances of the same ppoprf::Server can be created, for example to support a cluster of indistinguishable instances to scale throughput. Adds a new `ServerPrivateKey` which can be extracted and converted to a byte slice. Since it just wraps `RistrettoScalar` I picked this over serde traits. Also add a new `ppoprf::Server` contstructor which accepts a key rather than generating a new one. NB: This only represents the `oprf_key` field of the `Server` struct. The `GGM` instance has its own random internal state, so this commit IS NOT SUFFICIENT for repeatable behavior. A more complex key structure is necessary.
Confirm the various new methods work.
Verify that a `ppoprf::Server` created from a `ServerPrivateKey` produces identical output to the original.
|
Unfortunately, One design question is whether |
The `ristretto::Scalar` type is an array, which are `Copy` up to 32 bytes, so the clone() call is unnecessary. Addresses a clippy lint.
|
superseded by #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement private key import/export so identical instances can be created for horizontal scaling.
In support of brave/star-randsrv#175